diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2012-11-13 12:21:22 -0500 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2012-11-19 10:40:16 -0500 |
commit | fd25b4c2f226de818e1d2b71e3e681d28bcaf5ba (patch) | |
tree | dd1ce241709d2363e0d8b2c853f51dc5c897805c /kernel/sched/cputime.c | |
parent | 38ca9c927c7d3db61f57e3d3a9334958c3af6e9a (diff) |
vtime: Remove the underscore prefix invasion
Prepending irq-unsafe vtime APIs with underscores was actually
a bad idea as the result is a big mess in the API namespace that
is even waiting to be further extended. Also these helpers
are always called from irq safe callers except kvm. Just
provide a vtime_account_system_irqsafe() for this specific
case so that we can remove the underscore prefix on other
vtime functions.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Diffstat (limited to 'kernel/sched/cputime.c')
-rw-r--r-- | kernel/sched/cputime.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 8d859dae5bed..c0aa1ba752ea 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c | |||
@@ -433,20 +433,20 @@ void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | |||
433 | *st = cputime.stime; | 433 | *st = cputime.stime; |
434 | } | 434 | } |
435 | 435 | ||
436 | void vtime_account_system(struct task_struct *tsk) | 436 | void vtime_account_system_irqsafe(struct task_struct *tsk) |
437 | { | 437 | { |
438 | unsigned long flags; | 438 | unsigned long flags; |
439 | 439 | ||
440 | local_irq_save(flags); | 440 | local_irq_save(flags); |
441 | __vtime_account_system(tsk); | 441 | vtime_account_system(tsk); |
442 | local_irq_restore(flags); | 442 | local_irq_restore(flags); |
443 | } | 443 | } |
444 | EXPORT_SYMBOL_GPL(vtime_account_system); | 444 | EXPORT_SYMBOL_GPL(vtime_account_system_irqsafe); |
445 | 445 | ||
446 | /* | 446 | /* |
447 | * Archs that account the whole time spent in the idle task | 447 | * Archs that account the whole time spent in the idle task |
448 | * (outside irq) as idle time can rely on this and just implement | 448 | * (outside irq) as idle time can rely on this and just implement |
449 | * __vtime_account_system() and __vtime_account_idle(). Archs that | 449 | * vtime_account_system() and vtime_account_idle(). Archs that |
450 | * have other meaning of the idle time (s390 only includes the | 450 | * have other meaning of the idle time (s390 only includes the |
451 | * time spent by the CPU when it's in low power mode) must override | 451 | * time spent by the CPU when it's in low power mode) must override |
452 | * vtime_account(). | 452 | * vtime_account(). |
@@ -459,9 +459,9 @@ void vtime_account(struct task_struct *tsk) | |||
459 | local_irq_save(flags); | 459 | local_irq_save(flags); |
460 | 460 | ||
461 | if (in_interrupt() || !is_idle_task(tsk)) | 461 | if (in_interrupt() || !is_idle_task(tsk)) |
462 | __vtime_account_system(tsk); | 462 | vtime_account_system(tsk); |
463 | else | 463 | else |
464 | __vtime_account_idle(tsk); | 464 | vtime_account_idle(tsk); |
465 | 465 | ||
466 | local_irq_restore(flags); | 466 | local_irq_restore(flags); |
467 | } | 467 | } |