diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2013-07-15 10:35:55 -0400 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2013-08-14 11:14:56 -0400 |
commit | af2350bd12096dfd04e1090b90bfecea1f75f84e (patch) | |
tree | 838e36dc6f9ec7f2ae237652e1002597c64df070 /kernel/sched/cputime.c | |
parent | b854fafa4e06c50a92e00b39d75ee62083d986d6 (diff) |
vtime: Always debug check snapshot source _before_ updating it
The vtime delta update performed by get_vtime_delta() always check
that the source of the snapshot is valid.
Meanhile the snapshot updaters that rely on get_vtime_delta() also
set the new snapshot origin. But some of them do this right before
the call to get_vtime_delta(), making its debug check useless.
This is easily fixable by moving the snapshot origin update after
the call to get_vtime_delta(). The order doesn't matter there.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Kevin Hilman <khilman@linaro.org>
Diffstat (limited to 'kernel/sched/cputime.c')
-rw-r--r-- | kernel/sched/cputime.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index e9e742ed7280..c1d7493825ae 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c | |||
@@ -660,9 +660,9 @@ void vtime_account_system(struct task_struct *tsk) | |||
660 | void vtime_gen_account_irq_exit(struct task_struct *tsk) | 660 | void vtime_gen_account_irq_exit(struct task_struct *tsk) |
661 | { | 661 | { |
662 | write_seqlock(&tsk->vtime_seqlock); | 662 | write_seqlock(&tsk->vtime_seqlock); |
663 | __vtime_account_system(tsk); | ||
663 | if (context_tracking_in_user()) | 664 | if (context_tracking_in_user()) |
664 | tsk->vtime_snap_whence = VTIME_USER; | 665 | tsk->vtime_snap_whence = VTIME_USER; |
665 | __vtime_account_system(tsk); | ||
666 | write_sequnlock(&tsk->vtime_seqlock); | 666 | write_sequnlock(&tsk->vtime_seqlock); |
667 | } | 667 | } |
668 | 668 | ||
@@ -680,8 +680,8 @@ void vtime_account_user(struct task_struct *tsk) | |||
680 | void vtime_user_enter(struct task_struct *tsk) | 680 | void vtime_user_enter(struct task_struct *tsk) |
681 | { | 681 | { |
682 | write_seqlock(&tsk->vtime_seqlock); | 682 | write_seqlock(&tsk->vtime_seqlock); |
683 | tsk->vtime_snap_whence = VTIME_USER; | ||
684 | __vtime_account_system(tsk); | 683 | __vtime_account_system(tsk); |
684 | tsk->vtime_snap_whence = VTIME_USER; | ||
685 | write_sequnlock(&tsk->vtime_seqlock); | 685 | write_sequnlock(&tsk->vtime_seqlock); |
686 | } | 686 | } |
687 | 687 | ||