aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched.c
diff options
context:
space:
mode:
authorCon Kolivas <kernel@kolivas.org>2006-03-31 05:31:23 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2006-03-31 15:18:58 -0500
commit3dee386e14045484a6c41c8f03a263f9d79de740 (patch)
tree4b1643508ad94981e8d4deb5136d0a626e60932d /kernel/sched.c
parentdb1b1fefc2cecbff2e4214062fa8c680cb6e7b7d (diff)
[PATCH] sched: cleanup task_activated()
The activated flag in task_struct is used to track different sleep types and its usage is somewhat obfuscated. Convert the variable to an enum with more descriptive names without altering the function. Signed-off-by: Con Kolivas <kernel@kolivas.org> Acked-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r--kernel/sched.c24
1 files changed, 15 insertions, 9 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index 6e52e0adff80..f55ce5adac55 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -704,7 +704,7 @@ static int recalc_task_prio(task_t *p, unsigned long long now)
704 * prevent them suddenly becoming cpu hogs and starving 704 * prevent them suddenly becoming cpu hogs and starving
705 * other processes. 705 * other processes.
706 */ 706 */
707 if (p->mm && p->activated != -1 && 707 if (p->mm && p->sleep_type != SLEEP_NONINTERACTIVE &&
708 sleep_time > INTERACTIVE_SLEEP(p)) { 708 sleep_time > INTERACTIVE_SLEEP(p)) {
709 p->sleep_avg = JIFFIES_TO_NS(MAX_SLEEP_AVG - 709 p->sleep_avg = JIFFIES_TO_NS(MAX_SLEEP_AVG -
710 DEF_TIMESLICE); 710 DEF_TIMESLICE);
@@ -714,7 +714,7 @@ static int recalc_task_prio(task_t *p, unsigned long long now)
714 * limited in their sleep_avg rise as they 714 * limited in their sleep_avg rise as they
715 * are likely to be waiting on I/O 715 * are likely to be waiting on I/O
716 */ 716 */
717 if (p->activated == -1 && p->mm) { 717 if (p->sleep_type == SLEEP_NONINTERACTIVE && p->mm) {
718 if (p->sleep_avg >= INTERACTIVE_SLEEP(p)) 718 if (p->sleep_avg >= INTERACTIVE_SLEEP(p))
719 sleep_time = 0; 719 sleep_time = 0;
720 else if (p->sleep_avg + sleep_time >= 720 else if (p->sleep_avg + sleep_time >=
@@ -769,7 +769,7 @@ static void activate_task(task_t *p, runqueue_t *rq, int local)
769 * This checks to make sure it's not an uninterruptible task 769 * This checks to make sure it's not an uninterruptible task
770 * that is now waking up. 770 * that is now waking up.
771 */ 771 */
772 if (!p->activated) { 772 if (p->sleep_type == SLEEP_NORMAL) {
773 /* 773 /*
774 * Tasks which were woken up by interrupts (ie. hw events) 774 * Tasks which were woken up by interrupts (ie. hw events)
775 * are most likely of interactive nature. So we give them 775 * are most likely of interactive nature. So we give them
@@ -778,13 +778,13 @@ static void activate_task(task_t *p, runqueue_t *rq, int local)
778 * on a CPU, first time around: 778 * on a CPU, first time around:
779 */ 779 */
780 if (in_interrupt()) 780 if (in_interrupt())
781 p->activated = 2; 781 p->sleep_type = SLEEP_INTERRUPTED;
782 else { 782 else {
783 /* 783 /*
784 * Normal first-time wakeups get a credit too for 784 * Normal first-time wakeups get a credit too for
785 * on-runqueue time, but it will be weighted down: 785 * on-runqueue time, but it will be weighted down:
786 */ 786 */
787 p->activated = 1; 787 p->sleep_type = SLEEP_INTERACTIVE;
788 } 788 }
789 } 789 }
790 p->timestamp = now; 790 p->timestamp = now;
@@ -1272,7 +1272,7 @@ out_activate:
1272 * Tasks on involuntary sleep don't earn 1272 * Tasks on involuntary sleep don't earn
1273 * sleep_avg beyond just interactive state. 1273 * sleep_avg beyond just interactive state.
1274 */ 1274 */
1275 p->activated = -1; 1275 p->sleep_type = SLEEP_NONINTERACTIVE;
1276 } 1276 }
1277 1277
1278 /* 1278 /*
@@ -2875,6 +2875,12 @@ EXPORT_SYMBOL(sub_preempt_count);
2875 2875
2876#endif 2876#endif
2877 2877
2878static inline int interactive_sleep(enum sleep_type sleep_type)
2879{
2880 return (sleep_type == SLEEP_INTERACTIVE ||
2881 sleep_type == SLEEP_INTERRUPTED);
2882}
2883
2878/* 2884/*
2879 * schedule() is the main scheduler function. 2885 * schedule() is the main scheduler function.
2880 */ 2886 */
@@ -2998,12 +3004,12 @@ go_idle:
2998 queue = array->queue + idx; 3004 queue = array->queue + idx;
2999 next = list_entry(queue->next, task_t, run_list); 3005 next = list_entry(queue->next, task_t, run_list);
3000 3006
3001 if (!rt_task(next) && next->activated > 0) { 3007 if (!rt_task(next) && interactive_sleep(next->sleep_type)) {
3002 unsigned long long delta = now - next->timestamp; 3008 unsigned long long delta = now - next->timestamp;
3003 if (unlikely((long long)(now - next->timestamp) < 0)) 3009 if (unlikely((long long)(now - next->timestamp) < 0))
3004 delta = 0; 3010 delta = 0;
3005 3011
3006 if (next->activated == 1) 3012 if (next->sleep_type == SLEEP_INTERACTIVE)
3007 delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128; 3013 delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128;
3008 3014
3009 array = next->array; 3015 array = next->array;
@@ -3016,7 +3022,7 @@ go_idle:
3016 } else 3022 } else
3017 requeue_task(next, array); 3023 requeue_task(next, array);
3018 } 3024 }
3019 next->activated = 0; 3025 next->sleep_type = SLEEP_NORMAL;
3020switch_tasks: 3026switch_tasks:
3021 if (next == rq->idle) 3027 if (next == rq->idle)
3022 schedstat_inc(rq, sched_goidle); 3028 schedstat_inc(rq, sched_goidle);