aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2006-09-29 05:01:10 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-09-29 12:18:20 -0400
commit55a101f8f71a3d3dbda7b5c77083ffe47552f831 (patch)
tree52706df201efd82d09bed39562502b4caa357af4 /kernel/sched.c
parent29b884921634e1e01cbd276e1c9b8fc07a7e4a90 (diff)
[PATCH] kill PF_DEAD flag
After the previous change (->flags & PF_DEAD) <=> (->state == EXIT_DEAD), we don't need PF_DEAD any longer. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r--kernel/sched.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index e1646b044b69..a9405d7cc6ab 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1755,27 +1755,27 @@ static inline void finish_task_switch(struct rq *rq, struct task_struct *prev)
1755 __releases(rq->lock) 1755 __releases(rq->lock)
1756{ 1756{
1757 struct mm_struct *mm = rq->prev_mm; 1757 struct mm_struct *mm = rq->prev_mm;
1758 unsigned long prev_task_flags; 1758 long prev_state;
1759 1759
1760 rq->prev_mm = NULL; 1760 rq->prev_mm = NULL;
1761 1761
1762 /* 1762 /*
1763 * A task struct has one reference for the use as "current". 1763 * A task struct has one reference for the use as "current".
1764 * If a task dies, then it sets EXIT_ZOMBIE in tsk->exit_state and 1764 * If a task dies, then it sets EXIT_DEAD in tsk->state and calls
1765 * calls schedule one last time. The schedule call will never return, 1765 * schedule one last time. The schedule call will never return, and
1766 * and the scheduled task must drop that reference. 1766 * the scheduled task must drop that reference.
1767 * The test for EXIT_ZOMBIE must occur while the runqueue locks are 1767 * The test for EXIT_DEAD must occur while the runqueue locks are
1768 * still held, otherwise prev could be scheduled on another cpu, die 1768 * still held, otherwise prev could be scheduled on another cpu, die
1769 * there before we look at prev->state, and then the reference would 1769 * there before we look at prev->state, and then the reference would
1770 * be dropped twice. 1770 * be dropped twice.
1771 * Manfred Spraul <manfred@colorfullife.com> 1771 * Manfred Spraul <manfred@colorfullife.com>
1772 */ 1772 */
1773 prev_task_flags = prev->flags; 1773 prev_state = prev->state;
1774 finish_arch_switch(prev); 1774 finish_arch_switch(prev);
1775 finish_lock_switch(rq, prev); 1775 finish_lock_switch(rq, prev);
1776 if (mm) 1776 if (mm)
1777 mmdrop(mm); 1777 mmdrop(mm);
1778 if (unlikely(prev_task_flags & PF_DEAD)) { 1778 if (unlikely(prev_state == EXIT_DEAD)) {
1779 /* 1779 /*
1780 * Remove function-return probe instances associated with this 1780 * Remove function-return probe instances associated with this
1781 * task and put them back on the free list. 1781 * task and put them back on the free list.
@@ -5153,7 +5153,7 @@ static void migrate_dead(unsigned int dead_cpu, struct task_struct *p)
5153 BUG_ON(p->exit_state != EXIT_ZOMBIE && p->exit_state != EXIT_DEAD); 5153 BUG_ON(p->exit_state != EXIT_ZOMBIE && p->exit_state != EXIT_DEAD);
5154 5154
5155 /* Cannot have done final schedule yet: would have vanished. */ 5155 /* Cannot have done final schedule yet: would have vanished. */
5156 BUG_ON(p->flags & PF_DEAD); 5156 BUG_ON(p->state == EXIT_DEAD);
5157 5157
5158 get_task_struct(p); 5158 get_task_struct(p);
5159 5159