diff options
author | Jamie Iles <jamie.iles@picochip.com> | 2010-01-08 10:27:33 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-01-13 04:43:08 -0500 |
commit | 8381f65d097dad90416808314737dd7d3ae38ea9 (patch) | |
tree | 7cd0db1b5b719a629962571fdc26fd69bdee573c /kernel/sched.c | |
parent | cf5531148ff34938840d6da775c0a4ace442d573 (diff) |
sched/perf: Make sure irqs are disabled for perf_event_task_sched_in()
perf_event_task_sched_in() expects interrupts to be disabled,
but on architectures with __ARCH_WANT_INTERRUPTS_ON_CTXSW
defined, this isn't true. If this is defined, disable irqs
around the call in finish_task_switch().
Signed-off-by: Jamie Iles <jamie.iles@picochip.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
LKML-Reference: <1262964453-27370-1-git-send-email-jamie.iles@picochip.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r-- | kernel/sched.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index e507af086b42..c3ad3427a2a5 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -2783,7 +2783,13 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev) | |||
2783 | */ | 2783 | */ |
2784 | prev_state = prev->state; | 2784 | prev_state = prev->state; |
2785 | finish_arch_switch(prev); | 2785 | finish_arch_switch(prev); |
2786 | #ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW | ||
2787 | local_irq_disable(); | ||
2788 | #endif /* __ARCH_WANT_INTERRUPTS_ON_CTXSW */ | ||
2786 | perf_event_task_sched_in(current); | 2789 | perf_event_task_sched_in(current); |
2790 | #ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW | ||
2791 | local_irq_enable(); | ||
2792 | #endif /* __ARCH_WANT_INTERRUPTS_ON_CTXSW */ | ||
2787 | finish_lock_switch(rq, prev); | 2793 | finish_lock_switch(rq, prev); |
2788 | 2794 | ||
2789 | fire_sched_in_preempt_notifiers(current); | 2795 | fire_sched_in_preempt_notifiers(current); |