diff options
author | Ingo Molnar <mingo@elte.hu> | 2008-05-29 05:23:17 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-05-29 05:24:01 -0400 |
commit | f9305d4a0968201b2818dbed0dc8cb0d4ee7aeb3 (patch) | |
tree | e171e568f04bd25c7c2ff99b5ef673b917b6eae6 /kernel/sched.c | |
parent | f26a3988917913b3d11b2bd741601a2c64ab9204 (diff) |
revert ("sched: fair: weight calculations")
Yanmin Zhang reported:
Comparing with kernel 2.6.25, sysbench+mysql(oltp, readonly) has many
regressions with 2.6.26-rc1:
1) 8-core stoakley: 28%;
2) 16-core tigerton: 20%;
3) Itanium Montvale: 50%.
Bisect located this patch:
| 8f1bc385cfbab474db6c27b5af1e439614f3025c is first bad commit
| commit 8f1bc385cfbab474db6c27b5af1e439614f3025c
| Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
| Date: Sat Apr 19 19:45:00 2008 +0200
|
| sched: fair: weight calculations
Revert it to the 2.6.25 state.
Bisected-by: Yanmin Zhang <yanmin_zhang@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r-- | kernel/sched.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index cfa222a91539..4aac8aa16037 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -1368,9 +1368,6 @@ static void __resched_task(struct task_struct *p, int tif_bit) | |||
1368 | */ | 1368 | */ |
1369 | #define SRR(x, y) (((x) + (1UL << ((y) - 1))) >> (y)) | 1369 | #define SRR(x, y) (((x) + (1UL << ((y) - 1))) >> (y)) |
1370 | 1370 | ||
1371 | /* | ||
1372 | * delta *= weight / lw | ||
1373 | */ | ||
1374 | static unsigned long | 1371 | static unsigned long |
1375 | calc_delta_mine(unsigned long delta_exec, unsigned long weight, | 1372 | calc_delta_mine(unsigned long delta_exec, unsigned long weight, |
1376 | struct load_weight *lw) | 1373 | struct load_weight *lw) |
@@ -1393,6 +1390,12 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight, | |||
1393 | return (unsigned long)min(tmp, (u64)(unsigned long)LONG_MAX); | 1390 | return (unsigned long)min(tmp, (u64)(unsigned long)LONG_MAX); |
1394 | } | 1391 | } |
1395 | 1392 | ||
1393 | static inline unsigned long | ||
1394 | calc_delta_fair(unsigned long delta_exec, struct load_weight *lw) | ||
1395 | { | ||
1396 | return calc_delta_mine(delta_exec, NICE_0_LOAD, lw); | ||
1397 | } | ||
1398 | |||
1396 | static inline void update_load_add(struct load_weight *lw, unsigned long inc) | 1399 | static inline void update_load_add(struct load_weight *lw, unsigned long inc) |
1397 | { | 1400 | { |
1398 | lw->weight += inc; | 1401 | lw->weight += inc; |