diff options
author | Changli Gao <xiaosuo@gmail.com> | 2010-05-07 02:33:26 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-05-11 11:43:58 -0400 |
commit | a93d2f1744206827ccf416e2cdc5018aa503314e (patch) | |
tree | c4c9daf16536d8d58db275617e19898f6c5bdbd7 /kernel/sched.c | |
parent | af507ae8a0512a83728b17d8f8c5fa1561669f50 (diff) |
sched, wait: Use wrapper functions
epoll should not touch flags in wait_queue_t. This patch introduces a new
function __add_wait_queue_exclusive(), for the users, who use wait queue as a
LIFO queue.
__add_wait_queue_tail_exclusive() is introduced too instead of
add_wait_queue_exclusive_locked(). remove_wait_queue_locked() is removed, as
it is a duplicate of __remove_wait_queue(), disliked by users, and with less
users.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Davide Libenzi <davidel@xmailserver.org>
Cc: <containers@lists.linux-foundation.org>
LKML-Reference: <1273214006-2979-1-git-send-email-xiaosuo@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r-- | kernel/sched.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index 39aa9c7e22c0..b531d7934083 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -3983,8 +3983,7 @@ do_wait_for_common(struct completion *x, long timeout, int state) | |||
3983 | if (!x->done) { | 3983 | if (!x->done) { |
3984 | DECLARE_WAITQUEUE(wait, current); | 3984 | DECLARE_WAITQUEUE(wait, current); |
3985 | 3985 | ||
3986 | wait.flags |= WQ_FLAG_EXCLUSIVE; | 3986 | __add_wait_queue_tail_exclusive(&x->wait, &wait); |
3987 | __add_wait_queue_tail(&x->wait, &wait); | ||
3988 | do { | 3987 | do { |
3989 | if (signal_pending_state(state, current)) { | 3988 | if (signal_pending_state(state, current)) { |
3990 | timeout = -ERESTARTSYS; | 3989 | timeout = -ERESTARTSYS; |