aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched.c
diff options
context:
space:
mode:
authorGautham R Shenoy <ego@in.ibm.com>2008-01-25 15:08:02 -0500
committerIngo Molnar <mingo@elte.hu>2008-01-25 15:08:02 -0500
commit86ef5c9a8edd78e6bf92879f32329d89b2d55b5a (patch)
tree7bf46885326a6fdbb0c3596855408e9a5634dd3a /kernel/sched.c
parentd221938c049f4845da13c8593132595a6b9222a8 (diff)
cpu-hotplug: replace lock_cpu_hotplug() with get_online_cpus()
Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use get_online_cpus and put_online_cpus instead as it highlights the refcount semantics in these operations. The new API guarantees protection against the cpu-hotplug operation, but it doesn't guarantee serialized access to any of the local data structures. Hence the changes needs to be reviewed. In case of pseries_add_processor/pseries_remove_processor, use cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the cpu_present_map there. Signed-off-by: Gautham R Shenoy <ego@in.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r--kernel/sched.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index 86e55a9c2de6..672aa68bfeac 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7152,7 +7152,7 @@ static int load_balance_monitor(void *unused)
7152 int i, cpu, balanced = 1; 7152 int i, cpu, balanced = 1;
7153 7153
7154 /* Prevent cpus going down or coming up */ 7154 /* Prevent cpus going down or coming up */
7155 lock_cpu_hotplug(); 7155 get_online_cpus();
7156 /* lockout changes to doms_cur[] array */ 7156 /* lockout changes to doms_cur[] array */
7157 lock_doms_cur(); 7157 lock_doms_cur();
7158 /* 7158 /*
@@ -7186,7 +7186,7 @@ static int load_balance_monitor(void *unused)
7186 rcu_read_unlock(); 7186 rcu_read_unlock();
7187 7187
7188 unlock_doms_cur(); 7188 unlock_doms_cur();
7189 unlock_cpu_hotplug(); 7189 put_online_cpus();
7190 7190
7191 if (!balanced) 7191 if (!balanced)
7192 timeout = sysctl_sched_min_bal_int_shares; 7192 timeout = sysctl_sched_min_bal_int_shares;