diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2009-11-17 08:54:03 -0500 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2009-12-14 17:55:33 -0500 |
commit | 1d615482547584b9a8bb6316a58fed6ce90dd9ff (patch) | |
tree | 21dae4b70acb3ce0bdaeeaee1dbd970be41d26e2 /kernel/rtmutex.c | |
parent | fe841226bd954fba4fd79f037a876053fe9c3217 (diff) |
sched: Convert pi_lock to raw_spinlock
Convert locks which cannot be sleeping locks in preempt-rt to
raw_spinlocks.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/rtmutex.c')
-rw-r--r-- | kernel/rtmutex.c | 58 |
1 files changed, 29 insertions, 29 deletions
diff --git a/kernel/rtmutex.c b/kernel/rtmutex.c index 29bd4baf9e75..d33da470f9da 100644 --- a/kernel/rtmutex.c +++ b/kernel/rtmutex.c | |||
@@ -138,9 +138,9 @@ static void rt_mutex_adjust_prio(struct task_struct *task) | |||
138 | { | 138 | { |
139 | unsigned long flags; | 139 | unsigned long flags; |
140 | 140 | ||
141 | spin_lock_irqsave(&task->pi_lock, flags); | 141 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
142 | __rt_mutex_adjust_prio(task); | 142 | __rt_mutex_adjust_prio(task); |
143 | spin_unlock_irqrestore(&task->pi_lock, flags); | 143 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
144 | } | 144 | } |
145 | 145 | ||
146 | /* | 146 | /* |
@@ -195,7 +195,7 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
195 | /* | 195 | /* |
196 | * Task can not go away as we did a get_task() before ! | 196 | * Task can not go away as we did a get_task() before ! |
197 | */ | 197 | */ |
198 | spin_lock_irqsave(&task->pi_lock, flags); | 198 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
199 | 199 | ||
200 | waiter = task->pi_blocked_on; | 200 | waiter = task->pi_blocked_on; |
201 | /* | 201 | /* |
@@ -232,7 +232,7 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
232 | 232 | ||
233 | lock = waiter->lock; | 233 | lock = waiter->lock; |
234 | if (!spin_trylock(&lock->wait_lock)) { | 234 | if (!spin_trylock(&lock->wait_lock)) { |
235 | spin_unlock_irqrestore(&task->pi_lock, flags); | 235 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
236 | cpu_relax(); | 236 | cpu_relax(); |
237 | goto retry; | 237 | goto retry; |
238 | } | 238 | } |
@@ -253,13 +253,13 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
253 | plist_add(&waiter->list_entry, &lock->wait_list); | 253 | plist_add(&waiter->list_entry, &lock->wait_list); |
254 | 254 | ||
255 | /* Release the task */ | 255 | /* Release the task */ |
256 | spin_unlock_irqrestore(&task->pi_lock, flags); | 256 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
257 | put_task_struct(task); | 257 | put_task_struct(task); |
258 | 258 | ||
259 | /* Grab the next task */ | 259 | /* Grab the next task */ |
260 | task = rt_mutex_owner(lock); | 260 | task = rt_mutex_owner(lock); |
261 | get_task_struct(task); | 261 | get_task_struct(task); |
262 | spin_lock_irqsave(&task->pi_lock, flags); | 262 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
263 | 263 | ||
264 | if (waiter == rt_mutex_top_waiter(lock)) { | 264 | if (waiter == rt_mutex_top_waiter(lock)) { |
265 | /* Boost the owner */ | 265 | /* Boost the owner */ |
@@ -277,7 +277,7 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
277 | __rt_mutex_adjust_prio(task); | 277 | __rt_mutex_adjust_prio(task); |
278 | } | 278 | } |
279 | 279 | ||
280 | spin_unlock_irqrestore(&task->pi_lock, flags); | 280 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
281 | 281 | ||
282 | top_waiter = rt_mutex_top_waiter(lock); | 282 | top_waiter = rt_mutex_top_waiter(lock); |
283 | spin_unlock(&lock->wait_lock); | 283 | spin_unlock(&lock->wait_lock); |
@@ -288,7 +288,7 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
288 | goto again; | 288 | goto again; |
289 | 289 | ||
290 | out_unlock_pi: | 290 | out_unlock_pi: |
291 | spin_unlock_irqrestore(&task->pi_lock, flags); | 291 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
292 | out_put_task: | 292 | out_put_task: |
293 | put_task_struct(task); | 293 | put_task_struct(task); |
294 | 294 | ||
@@ -313,9 +313,9 @@ static inline int try_to_steal_lock(struct rt_mutex *lock, | |||
313 | if (pendowner == task) | 313 | if (pendowner == task) |
314 | return 1; | 314 | return 1; |
315 | 315 | ||
316 | spin_lock_irqsave(&pendowner->pi_lock, flags); | 316 | raw_spin_lock_irqsave(&pendowner->pi_lock, flags); |
317 | if (task->prio >= pendowner->prio) { | 317 | if (task->prio >= pendowner->prio) { |
318 | spin_unlock_irqrestore(&pendowner->pi_lock, flags); | 318 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); |
319 | return 0; | 319 | return 0; |
320 | } | 320 | } |
321 | 321 | ||
@@ -325,7 +325,7 @@ static inline int try_to_steal_lock(struct rt_mutex *lock, | |||
325 | * priority. | 325 | * priority. |
326 | */ | 326 | */ |
327 | if (likely(!rt_mutex_has_waiters(lock))) { | 327 | if (likely(!rt_mutex_has_waiters(lock))) { |
328 | spin_unlock_irqrestore(&pendowner->pi_lock, flags); | 328 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); |
329 | return 1; | 329 | return 1; |
330 | } | 330 | } |
331 | 331 | ||
@@ -333,7 +333,7 @@ static inline int try_to_steal_lock(struct rt_mutex *lock, | |||
333 | next = rt_mutex_top_waiter(lock); | 333 | next = rt_mutex_top_waiter(lock); |
334 | plist_del(&next->pi_list_entry, &pendowner->pi_waiters); | 334 | plist_del(&next->pi_list_entry, &pendowner->pi_waiters); |
335 | __rt_mutex_adjust_prio(pendowner); | 335 | __rt_mutex_adjust_prio(pendowner); |
336 | spin_unlock_irqrestore(&pendowner->pi_lock, flags); | 336 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); |
337 | 337 | ||
338 | /* | 338 | /* |
339 | * We are going to steal the lock and a waiter was | 339 | * We are going to steal the lock and a waiter was |
@@ -350,10 +350,10 @@ static inline int try_to_steal_lock(struct rt_mutex *lock, | |||
350 | * might be task: | 350 | * might be task: |
351 | */ | 351 | */ |
352 | if (likely(next->task != task)) { | 352 | if (likely(next->task != task)) { |
353 | spin_lock_irqsave(&task->pi_lock, flags); | 353 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
354 | plist_add(&next->pi_list_entry, &task->pi_waiters); | 354 | plist_add(&next->pi_list_entry, &task->pi_waiters); |
355 | __rt_mutex_adjust_prio(task); | 355 | __rt_mutex_adjust_prio(task); |
356 | spin_unlock_irqrestore(&task->pi_lock, flags); | 356 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
357 | } | 357 | } |
358 | return 1; | 358 | return 1; |
359 | } | 359 | } |
@@ -420,7 +420,7 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, | |||
420 | unsigned long flags; | 420 | unsigned long flags; |
421 | int chain_walk = 0, res; | 421 | int chain_walk = 0, res; |
422 | 422 | ||
423 | spin_lock_irqsave(&task->pi_lock, flags); | 423 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
424 | __rt_mutex_adjust_prio(task); | 424 | __rt_mutex_adjust_prio(task); |
425 | waiter->task = task; | 425 | waiter->task = task; |
426 | waiter->lock = lock; | 426 | waiter->lock = lock; |
@@ -434,17 +434,17 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, | |||
434 | 434 | ||
435 | task->pi_blocked_on = waiter; | 435 | task->pi_blocked_on = waiter; |
436 | 436 | ||
437 | spin_unlock_irqrestore(&task->pi_lock, flags); | 437 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
438 | 438 | ||
439 | if (waiter == rt_mutex_top_waiter(lock)) { | 439 | if (waiter == rt_mutex_top_waiter(lock)) { |
440 | spin_lock_irqsave(&owner->pi_lock, flags); | 440 | raw_spin_lock_irqsave(&owner->pi_lock, flags); |
441 | plist_del(&top_waiter->pi_list_entry, &owner->pi_waiters); | 441 | plist_del(&top_waiter->pi_list_entry, &owner->pi_waiters); |
442 | plist_add(&waiter->pi_list_entry, &owner->pi_waiters); | 442 | plist_add(&waiter->pi_list_entry, &owner->pi_waiters); |
443 | 443 | ||
444 | __rt_mutex_adjust_prio(owner); | 444 | __rt_mutex_adjust_prio(owner); |
445 | if (owner->pi_blocked_on) | 445 | if (owner->pi_blocked_on) |
446 | chain_walk = 1; | 446 | chain_walk = 1; |
447 | spin_unlock_irqrestore(&owner->pi_lock, flags); | 447 | raw_spin_unlock_irqrestore(&owner->pi_lock, flags); |
448 | } | 448 | } |
449 | else if (debug_rt_mutex_detect_deadlock(waiter, detect_deadlock)) | 449 | else if (debug_rt_mutex_detect_deadlock(waiter, detect_deadlock)) |
450 | chain_walk = 1; | 450 | chain_walk = 1; |
@@ -483,7 +483,7 @@ static void wakeup_next_waiter(struct rt_mutex *lock) | |||
483 | struct task_struct *pendowner; | 483 | struct task_struct *pendowner; |
484 | unsigned long flags; | 484 | unsigned long flags; |
485 | 485 | ||
486 | spin_lock_irqsave(¤t->pi_lock, flags); | 486 | raw_spin_lock_irqsave(¤t->pi_lock, flags); |
487 | 487 | ||
488 | waiter = rt_mutex_top_waiter(lock); | 488 | waiter = rt_mutex_top_waiter(lock); |
489 | plist_del(&waiter->list_entry, &lock->wait_list); | 489 | plist_del(&waiter->list_entry, &lock->wait_list); |
@@ -500,7 +500,7 @@ static void wakeup_next_waiter(struct rt_mutex *lock) | |||
500 | 500 | ||
501 | rt_mutex_set_owner(lock, pendowner, RT_MUTEX_OWNER_PENDING); | 501 | rt_mutex_set_owner(lock, pendowner, RT_MUTEX_OWNER_PENDING); |
502 | 502 | ||
503 | spin_unlock_irqrestore(¤t->pi_lock, flags); | 503 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); |
504 | 504 | ||
505 | /* | 505 | /* |
506 | * Clear the pi_blocked_on variable and enqueue a possible | 506 | * Clear the pi_blocked_on variable and enqueue a possible |
@@ -509,7 +509,7 @@ static void wakeup_next_waiter(struct rt_mutex *lock) | |||
509 | * waiter with higher priority than pending-owner->normal_prio | 509 | * waiter with higher priority than pending-owner->normal_prio |
510 | * is blocked on the unboosted (pending) owner. | 510 | * is blocked on the unboosted (pending) owner. |
511 | */ | 511 | */ |
512 | spin_lock_irqsave(&pendowner->pi_lock, flags); | 512 | raw_spin_lock_irqsave(&pendowner->pi_lock, flags); |
513 | 513 | ||
514 | WARN_ON(!pendowner->pi_blocked_on); | 514 | WARN_ON(!pendowner->pi_blocked_on); |
515 | WARN_ON(pendowner->pi_blocked_on != waiter); | 515 | WARN_ON(pendowner->pi_blocked_on != waiter); |
@@ -523,7 +523,7 @@ static void wakeup_next_waiter(struct rt_mutex *lock) | |||
523 | next = rt_mutex_top_waiter(lock); | 523 | next = rt_mutex_top_waiter(lock); |
524 | plist_add(&next->pi_list_entry, &pendowner->pi_waiters); | 524 | plist_add(&next->pi_list_entry, &pendowner->pi_waiters); |
525 | } | 525 | } |
526 | spin_unlock_irqrestore(&pendowner->pi_lock, flags); | 526 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); |
527 | 527 | ||
528 | wake_up_process(pendowner); | 528 | wake_up_process(pendowner); |
529 | } | 529 | } |
@@ -541,15 +541,15 @@ static void remove_waiter(struct rt_mutex *lock, | |||
541 | unsigned long flags; | 541 | unsigned long flags; |
542 | int chain_walk = 0; | 542 | int chain_walk = 0; |
543 | 543 | ||
544 | spin_lock_irqsave(¤t->pi_lock, flags); | 544 | raw_spin_lock_irqsave(¤t->pi_lock, flags); |
545 | plist_del(&waiter->list_entry, &lock->wait_list); | 545 | plist_del(&waiter->list_entry, &lock->wait_list); |
546 | waiter->task = NULL; | 546 | waiter->task = NULL; |
547 | current->pi_blocked_on = NULL; | 547 | current->pi_blocked_on = NULL; |
548 | spin_unlock_irqrestore(¤t->pi_lock, flags); | 548 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); |
549 | 549 | ||
550 | if (first && owner != current) { | 550 | if (first && owner != current) { |
551 | 551 | ||
552 | spin_lock_irqsave(&owner->pi_lock, flags); | 552 | raw_spin_lock_irqsave(&owner->pi_lock, flags); |
553 | 553 | ||
554 | plist_del(&waiter->pi_list_entry, &owner->pi_waiters); | 554 | plist_del(&waiter->pi_list_entry, &owner->pi_waiters); |
555 | 555 | ||
@@ -564,7 +564,7 @@ static void remove_waiter(struct rt_mutex *lock, | |||
564 | if (owner->pi_blocked_on) | 564 | if (owner->pi_blocked_on) |
565 | chain_walk = 1; | 565 | chain_walk = 1; |
566 | 566 | ||
567 | spin_unlock_irqrestore(&owner->pi_lock, flags); | 567 | raw_spin_unlock_irqrestore(&owner->pi_lock, flags); |
568 | } | 568 | } |
569 | 569 | ||
570 | WARN_ON(!plist_node_empty(&waiter->pi_list_entry)); | 570 | WARN_ON(!plist_node_empty(&waiter->pi_list_entry)); |
@@ -592,15 +592,15 @@ void rt_mutex_adjust_pi(struct task_struct *task) | |||
592 | struct rt_mutex_waiter *waiter; | 592 | struct rt_mutex_waiter *waiter; |
593 | unsigned long flags; | 593 | unsigned long flags; |
594 | 594 | ||
595 | spin_lock_irqsave(&task->pi_lock, flags); | 595 | raw_spin_lock_irqsave(&task->pi_lock, flags); |
596 | 596 | ||
597 | waiter = task->pi_blocked_on; | 597 | waiter = task->pi_blocked_on; |
598 | if (!waiter || waiter->list_entry.prio == task->prio) { | 598 | if (!waiter || waiter->list_entry.prio == task->prio) { |
599 | spin_unlock_irqrestore(&task->pi_lock, flags); | 599 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
600 | return; | 600 | return; |
601 | } | 601 | } |
602 | 602 | ||
603 | spin_unlock_irqrestore(&task->pi_lock, flags); | 603 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
604 | 604 | ||
605 | /* gets dropped in rt_mutex_adjust_prio_chain()! */ | 605 | /* gets dropped in rt_mutex_adjust_prio_chain()! */ |
606 | get_task_struct(task); | 606 | get_task_struct(task); |