diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2007-10-19 02:40:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-19 14:53:43 -0400 |
commit | ba25f9dcc4ea6e30839fcab5a5516f2176d5bfed (patch) | |
tree | 3123c03b25dd5c0cd24b6ab4fc16731217838157 /kernel/rtmutex-debug.c | |
parent | 9a2e70572e94e21e7ec4186702d045415422bda0 (diff) |
Use helpers to obtain task pid in printks
The task_struct->pid member is going to be deprecated, so start
using the helpers (task_pid_nr/task_pid_vnr/task_pid_nr_ns) in
the kernel.
The first thing to start with is the pid, printed to dmesg - in
this case we may safely use task_pid_nr(). Besides, printks produce
more (much more) than a half of all the explicit pid usage.
[akpm@linux-foundation.org: git-drm went and changed lots of stuff]
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/rtmutex-debug.c')
-rw-r--r-- | kernel/rtmutex-debug.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/kernel/rtmutex-debug.c b/kernel/rtmutex-debug.c index 6b0703db152d..56d73cb8826d 100644 --- a/kernel/rtmutex-debug.c +++ b/kernel/rtmutex-debug.c | |||
@@ -87,7 +87,7 @@ static int rt_trace_on = 1; | |||
87 | static void printk_task(struct task_struct *p) | 87 | static void printk_task(struct task_struct *p) |
88 | { | 88 | { |
89 | if (p) | 89 | if (p) |
90 | printk("%16s:%5d [%p, %3d]", p->comm, p->pid, p, p->prio); | 90 | printk("%16s:%5d [%p, %3d]", p->comm, task_pid_nr(p), p, p->prio); |
91 | else | 91 | else |
92 | printk("<none>"); | 92 | printk("<none>"); |
93 | } | 93 | } |
@@ -152,22 +152,25 @@ void debug_rt_mutex_print_deadlock(struct rt_mutex_waiter *waiter) | |||
152 | printk( "[ BUG: circular locking deadlock detected! ]\n"); | 152 | printk( "[ BUG: circular locking deadlock detected! ]\n"); |
153 | printk( "--------------------------------------------\n"); | 153 | printk( "--------------------------------------------\n"); |
154 | printk("%s/%d is deadlocking current task %s/%d\n\n", | 154 | printk("%s/%d is deadlocking current task %s/%d\n\n", |
155 | task->comm, task->pid, current->comm, current->pid); | 155 | task->comm, task_pid_nr(task), |
156 | current->comm, task_pid_nr(current)); | ||
156 | 157 | ||
157 | printk("\n1) %s/%d is trying to acquire this lock:\n", | 158 | printk("\n1) %s/%d is trying to acquire this lock:\n", |
158 | current->comm, current->pid); | 159 | current->comm, task_pid_nr(current)); |
159 | printk_lock(waiter->lock, 1); | 160 | printk_lock(waiter->lock, 1); |
160 | 161 | ||
161 | printk("\n2) %s/%d is blocked on this lock:\n", task->comm, task->pid); | 162 | printk("\n2) %s/%d is blocked on this lock:\n", |
163 | task->comm, task_pid_nr(task)); | ||
162 | printk_lock(waiter->deadlock_lock, 1); | 164 | printk_lock(waiter->deadlock_lock, 1); |
163 | 165 | ||
164 | debug_show_held_locks(current); | 166 | debug_show_held_locks(current); |
165 | debug_show_held_locks(task); | 167 | debug_show_held_locks(task); |
166 | 168 | ||
167 | printk("\n%s/%d's [blocked] stackdump:\n\n", task->comm, task->pid); | 169 | printk("\n%s/%d's [blocked] stackdump:\n\n", |
170 | task->comm, task_pid_nr(task)); | ||
168 | show_stack(task, NULL); | 171 | show_stack(task, NULL); |
169 | printk("\n%s/%d's [current] stackdump:\n\n", | 172 | printk("\n%s/%d's [current] stackdump:\n\n", |
170 | current->comm, current->pid); | 173 | current->comm, task_pid_nr(current)); |
171 | dump_stack(); | 174 | dump_stack(); |
172 | debug_show_all_locks(); | 175 | debug_show_all_locks(); |
173 | 176 | ||