diff options
author | Paul E. McKenney <paul.mckenney@linaro.org> | 2012-08-13 14:17:06 -0400 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2012-09-23 10:42:51 -0400 |
commit | c96ea7cfdd88d0a67c970502bc5313fede34b86b (patch) | |
tree | b5e8273bfa99f3ddf72e3a4fbfb6483b60d7f345 /kernel/rcutree.c | |
parent | c8020a67e625c714c4dbedc8ae2944b461e204ec (diff) |
rcu: Avoid spurious RCU CPU stall warnings
If a given CPU avoids the idle loop but also avoids starting a new
RCU grace period for a full minute, RCU can issue spurious RCU CPU
stall warnings. This commit fixes this issue by adding a check for
ongoing grace period to avoid these spurious stall warnings.
Reported-by: Becky Bruce <bgillbruce@gmail.com>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Diffstat (limited to 'kernel/rcutree.c')
-rw-r--r-- | kernel/rcutree.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/rcutree.c b/kernel/rcutree.c index 2cf8eb3e2d43..98f275296c6d 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c | |||
@@ -819,7 +819,8 @@ static void check_cpu_stall(struct rcu_state *rsp, struct rcu_data *rdp) | |||
819 | j = ACCESS_ONCE(jiffies); | 819 | j = ACCESS_ONCE(jiffies); |
820 | js = ACCESS_ONCE(rsp->jiffies_stall); | 820 | js = ACCESS_ONCE(rsp->jiffies_stall); |
821 | rnp = rdp->mynode; | 821 | rnp = rdp->mynode; |
822 | if ((ACCESS_ONCE(rnp->qsmask) & rdp->grpmask) && ULONG_CMP_GE(j, js)) { | 822 | if (rcu_gp_in_progress(rsp) && |
823 | (ACCESS_ONCE(rnp->qsmask) & rdp->grpmask) && ULONG_CMP_GE(j, js)) { | ||
823 | 824 | ||
824 | /* We haven't checked in, so go dump stack. */ | 825 | /* We haven't checked in, so go dump stack. */ |
825 | print_cpu_stall(rsp); | 826 | print_cpu_stall(rsp); |