diff options
author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-02-08 07:18:58 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-08 12:22:26 -0500 |
commit | 6b39c7bfbd1436836c0fb34c5b437fda1a7a3dd4 (patch) | |
tree | 60d3d9719eef3076527fcbf9c3cb362fe0f52d61 /kernel/ptrace.c | |
parent | 01b8b07a5d77d22e609267dcae74d15e3e9c5f13 (diff) |
kill PT_ATTACHED
Since the patch
"Fix ptrace_attach()/ptrace_traceme()/de_thread() race"
commit f5b40e363ad6041a96e3da32281d8faa191597b9
we set PT_ATTACHED and change child->parent "atomically" wrt task_list lock.
This means we can remove the checks like "PT_ATTACHED && ->parent != ptracer"
which were needed to catch the "ptrace attach is in progress" case. We can
also remove the flag itself since nobody else uses it.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/ptrace.c')
-rw-r--r-- | kernel/ptrace.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 628b03ab88a5..2dc00298e678 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c | |||
@@ -100,8 +100,7 @@ int ptrace_check_attach(struct task_struct *child, int kill) | |||
100 | */ | 100 | */ |
101 | read_lock(&tasklist_lock); | 101 | read_lock(&tasklist_lock); |
102 | if ((child->ptrace & PT_PTRACED) && child->parent == current && | 102 | if ((child->ptrace & PT_PTRACED) && child->parent == current && |
103 | (!(child->ptrace & PT_ATTACHED) || child->real_parent != current) | 103 | child->signal != NULL) { |
104 | && child->signal != NULL) { | ||
105 | ret = 0; | 104 | ret = 0; |
106 | spin_lock_irq(&child->sighand->siglock); | 105 | spin_lock_irq(&child->sighand->siglock); |
107 | if (task_is_stopped(child)) | 106 | if (task_is_stopped(child)) |
@@ -200,8 +199,7 @@ repeat: | |||
200 | goto bad; | 199 | goto bad; |
201 | 200 | ||
202 | /* Go */ | 201 | /* Go */ |
203 | task->ptrace |= PT_PTRACED | ((task->real_parent != current) | 202 | task->ptrace |= PT_PTRACED; |
204 | ? PT_ATTACHED : 0); | ||
205 | if (capable(CAP_SYS_PTRACE)) | 203 | if (capable(CAP_SYS_PTRACE)) |
206 | task->ptrace |= PT_PTRACE_CAP; | 204 | task->ptrace |= PT_PTRACE_CAP; |
207 | 205 | ||