diff options
author | Joe Perches <joe@perches.com> | 2014-12-10 18:45:53 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-12-10 20:41:10 -0500 |
commit | 1dc6244bd6d4f62239487fb0befc41c63e117290 (patch) | |
tree | e4297d59fc7ee4130059ad082ac7cf206195d408 /kernel/printk | |
parent | 9e3961a0979817c612b10b2da4f3045ec9faa779 (diff) |
printk: remove used-once early_vprintk
Eliminate the unlikely possibility of message interleaving for
early_printk/early_vprintk use.
early_vprintk can be done via the %pV extension so remove this
unnecessary function and change early_printk to have the equivalent
vprintk code.
All uses of early_printk already end with a newline so also remove the
unnecessary newline from the early_printk function.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/printk')
-rw-r--r-- | kernel/printk/printk.c | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index ced2b84b1cb7..4815c98ae175 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c | |||
@@ -1881,23 +1881,20 @@ static size_t cont_print_text(char *text, size_t size) { return 0; } | |||
1881 | #ifdef CONFIG_EARLY_PRINTK | 1881 | #ifdef CONFIG_EARLY_PRINTK |
1882 | struct console *early_console; | 1882 | struct console *early_console; |
1883 | 1883 | ||
1884 | void early_vprintk(const char *fmt, va_list ap) | ||
1885 | { | ||
1886 | if (early_console) { | ||
1887 | char buf[512]; | ||
1888 | int n = vscnprintf(buf, sizeof(buf), fmt, ap); | ||
1889 | |||
1890 | early_console->write(early_console, buf, n); | ||
1891 | } | ||
1892 | } | ||
1893 | |||
1894 | asmlinkage __visible void early_printk(const char *fmt, ...) | 1884 | asmlinkage __visible void early_printk(const char *fmt, ...) |
1895 | { | 1885 | { |
1896 | va_list ap; | 1886 | va_list ap; |
1887 | char buf[512]; | ||
1888 | int n; | ||
1889 | |||
1890 | if (!early_console) | ||
1891 | return; | ||
1897 | 1892 | ||
1898 | va_start(ap, fmt); | 1893 | va_start(ap, fmt); |
1899 | early_vprintk(fmt, ap); | 1894 | n = vscnprintf(buf, sizeof(buf), fmt, ap); |
1900 | va_end(ap); | 1895 | va_end(ap); |
1896 | |||
1897 | early_console->write(early_console, buf, n); | ||
1901 | } | 1898 | } |
1902 | #endif | 1899 | #endif |
1903 | 1900 | ||