diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2006-01-06 03:15:56 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-06 11:33:42 -0500 |
commit | ca0aec0f7a94bf9f07fefa8bfd23282d4e8ceb8a (patch) | |
tree | 5f31f11eba908545d5e02698fe9c163a8612dd26 /kernel/power | |
parent | b3a93a255ec33a04776ec50efb30b7a99168dda2 (diff) |
[PATCH] swsusp: make image size limit tunable
Make the suspend image size limit tunable via /sys/power/image_size.
It is necessary for systems on which there is a limited amount of swap
available for suspend. It can also be useful for optimizing performance of
swsusp on systems with 1 GB of RAM or more.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/power')
-rw-r--r-- | kernel/power/disk.c | 20 | ||||
-rw-r--r-- | kernel/power/power.h | 7 | ||||
-rw-r--r-- | kernel/power/swsusp.c | 10 |
3 files changed, 31 insertions, 6 deletions
diff --git a/kernel/power/disk.c b/kernel/power/disk.c index 9e51cdf7b78d..e24446f8d8cd 100644 --- a/kernel/power/disk.c +++ b/kernel/power/disk.c | |||
@@ -365,9 +365,29 @@ out: | |||
365 | 365 | ||
366 | power_attr(resume); | 366 | power_attr(resume); |
367 | 367 | ||
368 | static ssize_t image_size_show(struct subsystem * subsys, char *buf) | ||
369 | { | ||
370 | return sprintf(buf, "%u\n", image_size); | ||
371 | } | ||
372 | |||
373 | static ssize_t image_size_store(struct subsystem * subsys, const char * buf, size_t n) | ||
374 | { | ||
375 | unsigned int size; | ||
376 | |||
377 | if (sscanf(buf, "%u", &size) == 1) { | ||
378 | image_size = size; | ||
379 | return n; | ||
380 | } | ||
381 | |||
382 | return -EINVAL; | ||
383 | } | ||
384 | |||
385 | power_attr(image_size); | ||
386 | |||
368 | static struct attribute * g[] = { | 387 | static struct attribute * g[] = { |
369 | &disk_attr.attr, | 388 | &disk_attr.attr, |
370 | &resume_attr.attr, | 389 | &resume_attr.attr, |
390 | &image_size_attr.attr, | ||
371 | NULL, | 391 | NULL, |
372 | }; | 392 | }; |
373 | 393 | ||
diff --git a/kernel/power/power.h b/kernel/power/power.h index 9b0459903613..273a5b1d70be 100644 --- a/kernel/power/power.h +++ b/kernel/power/power.h | |||
@@ -52,11 +52,8 @@ extern const void __nosave_begin, __nosave_end; | |||
52 | extern unsigned int nr_copy_pages; | 52 | extern unsigned int nr_copy_pages; |
53 | extern struct pbe *pagedir_nosave; | 53 | extern struct pbe *pagedir_nosave; |
54 | 54 | ||
55 | /* | 55 | /* Preferred image size in MB (default 500) */ |
56 | * Preferred image size in MB (set it to zero to get the smallest | 56 | extern unsigned int image_size; |
57 | * image possible) | ||
58 | */ | ||
59 | #define IMAGE_SIZE 500 | ||
60 | 57 | ||
61 | extern asmlinkage int swsusp_arch_suspend(void); | 58 | extern asmlinkage int swsusp_arch_suspend(void); |
62 | extern asmlinkage int swsusp_arch_resume(void); | 59 | extern asmlinkage int swsusp_arch_resume(void); |
diff --git a/kernel/power/swsusp.c b/kernel/power/swsusp.c index 6d5ceaf4c364..d760a6a719f0 100644 --- a/kernel/power/swsusp.c +++ b/kernel/power/swsusp.c | |||
@@ -69,6 +69,14 @@ | |||
69 | 69 | ||
70 | #include "power.h" | 70 | #include "power.h" |
71 | 71 | ||
72 | /* | ||
73 | * Preferred image size in MB (tunable via /sys/power/image_size). | ||
74 | * When it is set to N, swsusp will do its best to ensure the image | ||
75 | * size will not exceed N MB, but if that is impossible, it will | ||
76 | * try to create the smallest image possible. | ||
77 | */ | ||
78 | unsigned int image_size = 500; | ||
79 | |||
72 | #ifdef CONFIG_HIGHMEM | 80 | #ifdef CONFIG_HIGHMEM |
73 | unsigned int count_highmem_pages(void); | 81 | unsigned int count_highmem_pages(void); |
74 | int save_highmem(void); | 82 | int save_highmem(void); |
@@ -647,7 +655,7 @@ int swsusp_shrink_memory(void) | |||
647 | if (!tmp) | 655 | if (!tmp) |
648 | return -ENOMEM; | 656 | return -ENOMEM; |
649 | pages += tmp; | 657 | pages += tmp; |
650 | } else if (size > (IMAGE_SIZE * 1024 * 1024) / PAGE_SIZE) { | 658 | } else if (size > (image_size * 1024 * 1024) / PAGE_SIZE) { |
651 | tmp = shrink_all_memory(SHRINK_BITE); | 659 | tmp = shrink_all_memory(SHRINK_BITE); |
652 | pages += tmp; | 660 | pages += tmp; |
653 | } | 661 | } |