diff options
author | Jeff Garzik <jgarzik@pobox.com> | 2005-10-20 10:06:09 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2005-10-20 10:06:09 -0400 |
commit | 902f90735b693550eb51a3989895f3148b8229d8 (patch) | |
tree | faddc60f0b27ed6d2a26f20c2c09f365dc4a2d7d /kernel/posix-cpu-timers.c | |
parent | 07b8fede6da76ae6a0f547716c44b801a116bb4a (diff) | |
parent | 93918e9afc76717176e9e114e79cdbb602a45ae8 (diff) |
Merge branch 'master'
Diffstat (limited to 'kernel/posix-cpu-timers.c')
-rw-r--r-- | kernel/posix-cpu-timers.c | 28 |
1 files changed, 11 insertions, 17 deletions
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c index 7a51a5597c33..b3f3edc475de 100644 --- a/kernel/posix-cpu-timers.c +++ b/kernel/posix-cpu-timers.c | |||
@@ -387,25 +387,19 @@ int posix_cpu_timer_del(struct k_itimer *timer) | |||
387 | if (unlikely(p == NULL)) | 387 | if (unlikely(p == NULL)) |
388 | return 0; | 388 | return 0; |
389 | 389 | ||
390 | spin_lock(&p->sighand->siglock); | ||
390 | if (!list_empty(&timer->it.cpu.entry)) { | 391 | if (!list_empty(&timer->it.cpu.entry)) { |
391 | read_lock(&tasklist_lock); | 392 | /* |
392 | if (unlikely(p->signal == NULL)) { | 393 | * Take us off the task's timer list. We don't need to |
393 | /* | 394 | * take tasklist_lock and check for the task being reaped. |
394 | * We raced with the reaping of the task. | 395 | * If it was reaped, it already called posix_cpu_timers_exit |
395 | * The deletion should have cleared us off the list. | 396 | * and posix_cpu_timers_exit_group to clear all the timers |
396 | */ | 397 | * that pointed to it. |
397 | BUG_ON(!list_empty(&timer->it.cpu.entry)); | 398 | */ |
398 | } else { | 399 | list_del(&timer->it.cpu.entry); |
399 | /* | 400 | put_task_struct(p); |
400 | * Take us off the task's timer list. | ||
401 | */ | ||
402 | spin_lock(&p->sighand->siglock); | ||
403 | list_del(&timer->it.cpu.entry); | ||
404 | spin_unlock(&p->sighand->siglock); | ||
405 | } | ||
406 | read_unlock(&tasklist_lock); | ||
407 | } | 401 | } |
408 | put_task_struct(p); | 402 | spin_unlock(&p->sighand->siglock); |
409 | 403 | ||
410 | return 0; | 404 | return 0; |
411 | } | 405 | } |