aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/perf_event.c
diff options
context:
space:
mode:
authorStephane Eranian <eranian@google.com>2010-10-15 09:26:01 -0400
committerIngo Molnar <mingo@elte.hu>2010-10-18 13:58:46 -0400
commitc530ccd9a1864a44a7ff35826681229ce9f2357a (patch)
tree51cb7ae96aa2b6e144686e850255344b2d94b888 /kernel/perf_event.c
parentf92f6e6ee35d2779aa62e70f78ad8e1cd417eb52 (diff)
perf_events: Fix bogus context time tracking
You can only call update_context_time() when the context is active, i.e., the thread it is attached to is still running. However, perf_event_read() can be called even when the context is inactive, e.g., user read() the counters. The call to update_context_time() must be conditioned on the status of the context, otherwise, bogus time_enabled, time_running may be returned. Here is an example on AMD64. The task program is an example from libpfm4. The -p prints deltas every 1s. $ task -p -e cpu_clk_unhalted sleep 5 2,266,610 cpu_clk_unhalted (0.00% scaling, ena=2,158,982, run=2,158,982) 0 cpu_clk_unhalted (0.00% scaling, ena=2,158,982, run=2,158,982) 0 cpu_clk_unhalted (0.00% scaling, ena=2,158,982, run=2,158,982) 0 cpu_clk_unhalted (0.00% scaling, ena=2,158,982, run=2,158,982) 0 cpu_clk_unhalted (0.00% scaling, ena=2,158,982, run=2,158,982) 5,242,358,071 cpu_clk_unhalted (99.95% scaling, ena=5,000,359,984, run=2,319,270) Whereas if you don't read deltas, e.g., no call to perf_event_read() until the process terminates: $ task -e cpu_clk_unhalted sleep 5 2,497,783 cpu_clk_unhalted (0.00% scaling, ena=2,376,899, run=2,376,899) Notice that time_enable, time_running are bogus in the first example causing bogus scaling. This patch fixes the problem, by conditionally calling update_context_time() in perf_event_read(). Signed-off-by: Stephane Eranian <eranian@google.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: stable@kernel.org LKML-Reference: <4cb856dc.51edd80a.5ae0.38fb@mx.google.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/perf_event.c')
-rw-r--r--kernel/perf_event.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index 1ec3916ffef0..e7eeba1794fd 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -1780,7 +1780,13 @@ static u64 perf_event_read(struct perf_event *event)
1780 unsigned long flags; 1780 unsigned long flags;
1781 1781
1782 raw_spin_lock_irqsave(&ctx->lock, flags); 1782 raw_spin_lock_irqsave(&ctx->lock, flags);
1783 update_context_time(ctx); 1783 /*
1784 * may read while context is not active
1785 * (e.g., thread is blocked), in that case
1786 * we cannot update context time
1787 */
1788 if (ctx->is_active)
1789 update_context_time(ctx);
1784 update_event_times(event); 1790 update_event_times(event);
1785 raw_spin_unlock_irqrestore(&ctx->lock, flags); 1791 raw_spin_unlock_irqrestore(&ctx->lock, flags);
1786 } 1792 }