diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2009-05-05 11:50:25 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-05-05 14:18:32 -0400 |
commit | 22c1558e51c210787c6cf75d8905246fc91ec030 (patch) | |
tree | 40949ad88dcba74df009437a3270fda4e938cb3f /kernel/perf_counter.c | |
parent | c5078f78b455fbf67ea71442c7e7ca8acf9ff095 (diff) |
perf_counter: fix the output lock
Use -1 instead of 0 as unlocked, since 0 is a valid cpu number.
( This is not an issue right now but will be once we allow multiple
counters to output to the same mmap area. )
[ Impact: prepare code for multi-counter profile output ]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
LKML-Reference: <20090505155437.232686598@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/perf_counter.c')
-rw-r--r-- | kernel/perf_counter.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c index 2d1342738305..c881afef997b 100644 --- a/kernel/perf_counter.c +++ b/kernel/perf_counter.c | |||
@@ -1409,6 +1409,7 @@ static int perf_mmap_data_alloc(struct perf_counter *counter, int nr_pages) | |||
1409 | } | 1409 | } |
1410 | 1410 | ||
1411 | data->nr_pages = nr_pages; | 1411 | data->nr_pages = nr_pages; |
1412 | atomic_set(&data->lock, -1); | ||
1412 | 1413 | ||
1413 | rcu_assign_pointer(counter->data, data); | 1414 | rcu_assign_pointer(counter->data, data); |
1414 | 1415 | ||
@@ -1755,7 +1756,7 @@ static void perf_output_lock(struct perf_output_handle *handle) | |||
1755 | if (in_nmi() && atomic_read(&data->lock) == cpu) | 1756 | if (in_nmi() && atomic_read(&data->lock) == cpu) |
1756 | return; | 1757 | return; |
1757 | 1758 | ||
1758 | while (atomic_cmpxchg(&data->lock, 0, cpu) != 0) | 1759 | while (atomic_cmpxchg(&data->lock, -1, cpu) != -1) |
1759 | cpu_relax(); | 1760 | cpu_relax(); |
1760 | 1761 | ||
1761 | handle->locked = 1; | 1762 | handle->locked = 1; |
@@ -1784,7 +1785,7 @@ again: | |||
1784 | * NMI can happen here, which means we can miss a done_head update. | 1785 | * NMI can happen here, which means we can miss a done_head update. |
1785 | */ | 1786 | */ |
1786 | 1787 | ||
1787 | cpu = atomic_xchg(&data->lock, 0); | 1788 | cpu = atomic_xchg(&data->lock, -1); |
1788 | WARN_ON_ONCE(cpu != smp_processor_id()); | 1789 | WARN_ON_ONCE(cpu != smp_processor_id()); |
1789 | 1790 | ||
1790 | /* | 1791 | /* |
@@ -1794,7 +1795,7 @@ again: | |||
1794 | /* | 1795 | /* |
1795 | * Since we had it locked, we can lock it again. | 1796 | * Since we had it locked, we can lock it again. |
1796 | */ | 1797 | */ |
1797 | while (atomic_cmpxchg(&data->lock, 0, cpu) != 0) | 1798 | while (atomic_cmpxchg(&data->lock, -1, cpu) != -1) |
1798 | cpu_relax(); | 1799 | cpu_relax(); |
1799 | 1800 | ||
1800 | goto again; | 1801 | goto again; |