aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/perf_counter.c
diff options
context:
space:
mode:
authorPeter Zijlstra <a.p.zijlstra@chello.nl>2009-05-20 06:21:21 -0400
committerIngo Molnar <mingo@elte.hu>2009-05-20 06:43:33 -0400
commitb986d7ec0f8b7ea3cc7366d80a137fbe839df227 (patch)
treead3e9c473b8790f800cbf9e13e3fee01230def52 /kernel/perf_counter.c
parent26b119bc811a73bac6ecf95bdf284bf31c7955f0 (diff)
perf_counter: Optimize disable of time based sw counters
Currently we call hrtimer_cancel() unconditionally on disable of time based software counters. Avoid when possible. [ Impact: micro-optimize the code ] Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: John Kacur <jkacur@redhat.com> LKML-Reference: <20090520102553.388185031@chello.nl> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/perf_counter.c')
-rw-r--r--kernel/perf_counter.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index db02eb16c777..473ed2cafbfc 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -2716,7 +2716,8 @@ static int cpu_clock_perf_counter_enable(struct perf_counter *counter)
2716 2716
2717static void cpu_clock_perf_counter_disable(struct perf_counter *counter) 2717static void cpu_clock_perf_counter_disable(struct perf_counter *counter)
2718{ 2718{
2719 hrtimer_cancel(&counter->hw.hrtimer); 2719 if (counter->hw.irq_period)
2720 hrtimer_cancel(&counter->hw.hrtimer);
2720 cpu_clock_perf_counter_update(counter); 2721 cpu_clock_perf_counter_update(counter);
2721} 2722}
2722 2723
@@ -2767,7 +2768,8 @@ static int task_clock_perf_counter_enable(struct perf_counter *counter)
2767 2768
2768static void task_clock_perf_counter_disable(struct perf_counter *counter) 2769static void task_clock_perf_counter_disable(struct perf_counter *counter)
2769{ 2770{
2770 hrtimer_cancel(&counter->hw.hrtimer); 2771 if (counter->hw.irq_period)
2772 hrtimer_cancel(&counter->hw.hrtimer);
2771 task_clock_perf_counter_update(counter, counter->ctx->time); 2773 task_clock_perf_counter_update(counter, counter->ctx->time);
2772 2774
2773} 2775}