diff options
author | Steven Rostedt <rostedt@goodmis.org> | 2013-05-15 15:46:23 -0400 |
---|---|---|
committer | Catalin Marinas <catalin.marinas@arm.com> | 2013-05-17 04:53:36 -0400 |
commit | 89c837351db0b9b52fd572ec8b0445a42e59b75c (patch) | |
tree | 8ca801aa87cc74ce286c6e75b010752e409f4856 /kernel/module.c | |
parent | 06c9494c0e9bdfcaa14d6d2b096a0ff7abe8494f (diff) |
kmemleak: No need for scanning specific module sections
As kmemleak now scans all module sections that are allocated, writable
and non executable, there's no need to scan individual sections that
might reference data.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'kernel/module.c')
-rw-r--r-- | kernel/module.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/kernel/module.c b/kernel/module.c index 06f496a5d182..cab4bce49c23 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -2769,24 +2769,11 @@ static void find_module_sections(struct module *mod, struct load_info *info) | |||
2769 | mod->trace_events = section_objs(info, "_ftrace_events", | 2769 | mod->trace_events = section_objs(info, "_ftrace_events", |
2770 | sizeof(*mod->trace_events), | 2770 | sizeof(*mod->trace_events), |
2771 | &mod->num_trace_events); | 2771 | &mod->num_trace_events); |
2772 | /* | ||
2773 | * This section contains pointers to allocated objects in the trace | ||
2774 | * code and not scanning it leads to false positives. | ||
2775 | */ | ||
2776 | kmemleak_scan_area(mod->trace_events, sizeof(*mod->trace_events) * | ||
2777 | mod->num_trace_events, GFP_KERNEL); | ||
2778 | #endif | 2772 | #endif |
2779 | #ifdef CONFIG_TRACING | 2773 | #ifdef CONFIG_TRACING |
2780 | mod->trace_bprintk_fmt_start = section_objs(info, "__trace_printk_fmt", | 2774 | mod->trace_bprintk_fmt_start = section_objs(info, "__trace_printk_fmt", |
2781 | sizeof(*mod->trace_bprintk_fmt_start), | 2775 | sizeof(*mod->trace_bprintk_fmt_start), |
2782 | &mod->num_trace_bprintk_fmt); | 2776 | &mod->num_trace_bprintk_fmt); |
2783 | /* | ||
2784 | * This section contains pointers to allocated objects in the trace | ||
2785 | * code and not scanning it leads to false positives. | ||
2786 | */ | ||
2787 | kmemleak_scan_area(mod->trace_bprintk_fmt_start, | ||
2788 | sizeof(*mod->trace_bprintk_fmt_start) * | ||
2789 | mod->num_trace_bprintk_fmt, GFP_KERNEL); | ||
2790 | #endif | 2777 | #endif |
2791 | #ifdef CONFIG_FTRACE_MCOUNT_RECORD | 2778 | #ifdef CONFIG_FTRACE_MCOUNT_RECORD |
2792 | /* sechdrs[0].sh_size is always zero */ | 2779 | /* sechdrs[0].sh_size is always zero */ |