diff options
| author | David Woodhouse <David.Woodhouse@intel.com> | 2008-07-25 10:40:14 -0400 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2008-07-25 10:40:14 -0400 |
| commit | ff877ea80efa2015b6263766f78ee42c2a1b32f9 (patch) | |
| tree | 85205005c611ab774702148558321c6fb92f1ccd /kernel/marker.c | |
| parent | 30821fee4f0cb3e6d241d9f7ddc37742212e3eb7 (diff) | |
| parent | d37e6bf68fc1eb34a4ad21d9ae8890ed37ea80e7 (diff) | |
Merge branch 'linux-next' of git://git.infradead.org/~dedekind/ubi-2.6
Diffstat (limited to 'kernel/marker.c')
| -rw-r--r-- | kernel/marker.c | 30 |
1 files changed, 14 insertions, 16 deletions
diff --git a/kernel/marker.c b/kernel/marker.c index b5a9fe1d50d5..1abfb923b761 100644 --- a/kernel/marker.c +++ b/kernel/marker.c | |||
| @@ -55,8 +55,8 @@ static DEFINE_MUTEX(markers_mutex); | |||
| 55 | struct marker_entry { | 55 | struct marker_entry { |
| 56 | struct hlist_node hlist; | 56 | struct hlist_node hlist; |
| 57 | char *format; | 57 | char *format; |
| 58 | void (*call)(const struct marker *mdata, /* Probe wrapper */ | 58 | /* Probe wrapper */ |
| 59 | void *call_private, const char *fmt, ...); | 59 | void (*call)(const struct marker *mdata, void *call_private, ...); |
| 60 | struct marker_probe_closure single; | 60 | struct marker_probe_closure single; |
| 61 | struct marker_probe_closure *multi; | 61 | struct marker_probe_closure *multi; |
| 62 | int refcount; /* Number of times armed. 0 if disarmed. */ | 62 | int refcount; /* Number of times armed. 0 if disarmed. */ |
| @@ -91,15 +91,13 @@ EXPORT_SYMBOL_GPL(__mark_empty_function); | |||
| 91 | * marker_probe_cb Callback that prepares the variable argument list for probes. | 91 | * marker_probe_cb Callback that prepares the variable argument list for probes. |
| 92 | * @mdata: pointer of type struct marker | 92 | * @mdata: pointer of type struct marker |
| 93 | * @call_private: caller site private data | 93 | * @call_private: caller site private data |
| 94 | * @fmt: format string | ||
| 95 | * @...: Variable argument list. | 94 | * @...: Variable argument list. |
| 96 | * | 95 | * |
| 97 | * Since we do not use "typical" pointer based RCU in the 1 argument case, we | 96 | * Since we do not use "typical" pointer based RCU in the 1 argument case, we |
| 98 | * need to put a full smp_rmb() in this branch. This is why we do not use | 97 | * need to put a full smp_rmb() in this branch. This is why we do not use |
| 99 | * rcu_dereference() for the pointer read. | 98 | * rcu_dereference() for the pointer read. |
| 100 | */ | 99 | */ |
| 101 | void marker_probe_cb(const struct marker *mdata, void *call_private, | 100 | void marker_probe_cb(const struct marker *mdata, void *call_private, ...) |
| 102 | const char *fmt, ...) | ||
| 103 | { | 101 | { |
| 104 | va_list args; | 102 | va_list args; |
| 105 | char ptype; | 103 | char ptype; |
| @@ -120,8 +118,9 @@ void marker_probe_cb(const struct marker *mdata, void *call_private, | |||
| 120 | /* Must read the ptr before private data. They are not data | 118 | /* Must read the ptr before private data. They are not data |
| 121 | * dependant, so we put an explicit smp_rmb() here. */ | 119 | * dependant, so we put an explicit smp_rmb() here. */ |
| 122 | smp_rmb(); | 120 | smp_rmb(); |
| 123 | va_start(args, fmt); | 121 | va_start(args, call_private); |
| 124 | func(mdata->single.probe_private, call_private, fmt, &args); | 122 | func(mdata->single.probe_private, call_private, mdata->format, |
| 123 | &args); | ||
| 125 | va_end(args); | 124 | va_end(args); |
| 126 | } else { | 125 | } else { |
| 127 | struct marker_probe_closure *multi; | 126 | struct marker_probe_closure *multi; |
| @@ -136,9 +135,9 @@ void marker_probe_cb(const struct marker *mdata, void *call_private, | |||
| 136 | smp_read_barrier_depends(); | 135 | smp_read_barrier_depends(); |
| 137 | multi = mdata->multi; | 136 | multi = mdata->multi; |
| 138 | for (i = 0; multi[i].func; i++) { | 137 | for (i = 0; multi[i].func; i++) { |
| 139 | va_start(args, fmt); | 138 | va_start(args, call_private); |
| 140 | multi[i].func(multi[i].probe_private, call_private, fmt, | 139 | multi[i].func(multi[i].probe_private, call_private, |
| 141 | &args); | 140 | mdata->format, &args); |
| 142 | va_end(args); | 141 | va_end(args); |
| 143 | } | 142 | } |
| 144 | } | 143 | } |
| @@ -150,13 +149,11 @@ EXPORT_SYMBOL_GPL(marker_probe_cb); | |||
| 150 | * marker_probe_cb Callback that does not prepare the variable argument list. | 149 | * marker_probe_cb Callback that does not prepare the variable argument list. |
| 151 | * @mdata: pointer of type struct marker | 150 | * @mdata: pointer of type struct marker |
| 152 | * @call_private: caller site private data | 151 | * @call_private: caller site private data |
| 153 | * @fmt: format string | ||
| 154 | * @...: Variable argument list. | 152 | * @...: Variable argument list. |
| 155 | * | 153 | * |
| 156 | * Should be connected to markers "MARK_NOARGS". | 154 | * Should be connected to markers "MARK_NOARGS". |
| 157 | */ | 155 | */ |
| 158 | void marker_probe_cb_noarg(const struct marker *mdata, | 156 | void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...) |
| 159 | void *call_private, const char *fmt, ...) | ||
| 160 | { | 157 | { |
| 161 | va_list args; /* not initialized */ | 158 | va_list args; /* not initialized */ |
| 162 | char ptype; | 159 | char ptype; |
| @@ -172,7 +169,8 @@ void marker_probe_cb_noarg(const struct marker *mdata, | |||
| 172 | /* Must read the ptr before private data. They are not data | 169 | /* Must read the ptr before private data. They are not data |
| 173 | * dependant, so we put an explicit smp_rmb() here. */ | 170 | * dependant, so we put an explicit smp_rmb() here. */ |
| 174 | smp_rmb(); | 171 | smp_rmb(); |
| 175 | func(mdata->single.probe_private, call_private, fmt, &args); | 172 | func(mdata->single.probe_private, call_private, mdata->format, |
| 173 | &args); | ||
| 176 | } else { | 174 | } else { |
| 177 | struct marker_probe_closure *multi; | 175 | struct marker_probe_closure *multi; |
| 178 | int i; | 176 | int i; |
| @@ -186,8 +184,8 @@ void marker_probe_cb_noarg(const struct marker *mdata, | |||
| 186 | smp_read_barrier_depends(); | 184 | smp_read_barrier_depends(); |
| 187 | multi = mdata->multi; | 185 | multi = mdata->multi; |
| 188 | for (i = 0; multi[i].func; i++) | 186 | for (i = 0; multi[i].func; i++) |
| 189 | multi[i].func(multi[i].probe_private, call_private, fmt, | 187 | multi[i].func(multi[i].probe_private, call_private, |
| 190 | &args); | 188 | mdata->format, &args); |
| 191 | } | 189 | } |
| 192 | preempt_enable(); | 190 | preempt_enable(); |
| 193 | } | 191 | } |
