diff options
author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 17:43:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:45 -0400 |
commit | 363da4022c2753bf4b4b54a1bb9e4527fdcb9d5d (patch) | |
tree | 103922ef0f185daebf5a3e8029663ab78eaed363 /kernel/kmod.c | |
parent | c70a626d3eba373514c72287c93588b6974a0059 (diff) |
call_usermodehelper: no need to unblock signals
____call_usermodehelper() correctly calls flush_signal_handlers() to set
SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending() are not
needed.
This kthread was forked by workqueue thread, all signals must be unblocked
and ignored, no pending signal is possible.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/kmod.c')
-rw-r--r-- | kernel/kmod.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/kmod.c b/kernel/kmod.c index 6194ec2f737b..7efba6f8e3ec 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c | |||
@@ -134,11 +134,8 @@ static int ____call_usermodehelper(void *data) | |||
134 | struct subprocess_info *sub_info = data; | 134 | struct subprocess_info *sub_info = data; |
135 | int retval; | 135 | int retval; |
136 | 136 | ||
137 | /* Unblock all signals */ | ||
138 | spin_lock_irq(¤t->sighand->siglock); | 137 | spin_lock_irq(¤t->sighand->siglock); |
139 | flush_signal_handlers(current, 1); | 138 | flush_signal_handlers(current, 1); |
140 | sigemptyset(¤t->blocked); | ||
141 | recalc_sigpending(); | ||
142 | spin_unlock_irq(¤t->sighand->siglock); | 139 | spin_unlock_irq(¤t->sighand->siglock); |
143 | 140 | ||
144 | /* We can run anywhere, unlike our parent keventd(). */ | 141 | /* We can run anywhere, unlike our parent keventd(). */ |