diff options
author | Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> | 2007-10-17 02:27:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:54 -0400 |
commit | d768281e97a403815467102bc4b677f6c425a42b (patch) | |
tree | 6ab7d064ffde0d105c256d0fbd7f1c629c54d37a /kernel/kexec.c | |
parent | fd59d231f81cb02870b9cf15f456a897f3669b4e (diff) |
add-vmcore: cleanup the coding style according to Andrew's comments
[1/3] Cleanup the coding style according to Andrew's comments:
http://lists.infradead.org/pipermail/kexec/2007-August/000522.html
- vmcoreinfo_append_str() should have suitable __attribute__s so that
the compiler can check its use.
- vmcoreinfo_max_size should have size_t.
- Use get_seconds() instead of xtime.tv_sec.
- Use init_uts_ns.name.release instead of UTS_RELEASE.
Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/kexec.c')
-rw-r--r-- | kernel/kexec.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/kexec.c b/kernel/kexec.c index 67828befbfc3..b979b010b6d8 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c | |||
@@ -38,8 +38,8 @@ note_buf_t* crash_notes; | |||
38 | /* vmcoreinfo stuff */ | 38 | /* vmcoreinfo stuff */ |
39 | unsigned char vmcoreinfo_data[VMCOREINFO_BYTES]; | 39 | unsigned char vmcoreinfo_data[VMCOREINFO_BYTES]; |
40 | u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; | 40 | u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; |
41 | unsigned int vmcoreinfo_size = 0; | 41 | size_t vmcoreinfo_size; |
42 | unsigned int vmcoreinfo_max_size = sizeof(vmcoreinfo_data); | 42 | size_t vmcoreinfo_max_size = sizeof(vmcoreinfo_data); |
43 | 43 | ||
44 | /* Location of the reserved area for the crash kernel */ | 44 | /* Location of the reserved area for the crash kernel */ |
45 | struct resource crashk_res = { | 45 | struct resource crashk_res = { |
@@ -1153,7 +1153,7 @@ void crash_save_vmcoreinfo(void) | |||
1153 | if (!vmcoreinfo_size) | 1153 | if (!vmcoreinfo_size) |
1154 | return; | 1154 | return; |
1155 | 1155 | ||
1156 | vmcoreinfo_append_str("CRASHTIME=%d", xtime.tv_sec); | 1156 | vmcoreinfo_append_str("CRASHTIME=%ld", get_seconds()); |
1157 | 1157 | ||
1158 | buf = (u32 *)vmcoreinfo_note; | 1158 | buf = (u32 *)vmcoreinfo_note; |
1159 | 1159 | ||
@@ -1195,8 +1195,8 @@ unsigned long __attribute__ ((weak)) paddr_vmcoreinfo_note(void) | |||
1195 | 1195 | ||
1196 | static int __init crash_save_vmcoreinfo_init(void) | 1196 | static int __init crash_save_vmcoreinfo_init(void) |
1197 | { | 1197 | { |
1198 | vmcoreinfo_append_str("OSRELEASE=%s\n", UTS_RELEASE); | 1198 | vmcoreinfo_append_str("OSRELEASE=%s\n", init_uts_ns.name.release); |
1199 | vmcoreinfo_append_str("PAGESIZE=%d\n", PAGE_SIZE); | 1199 | vmcoreinfo_append_str("PAGESIZE=%ld\n", PAGE_SIZE); |
1200 | 1200 | ||
1201 | SYMBOL(init_uts_ns); | 1201 | SYMBOL(init_uts_ns); |
1202 | SYMBOL(node_online_map); | 1202 | SYMBOL(node_online_map); |