diff options
author | Oleg Nesterov <oleg@redhat.com> | 2008-11-17 09:40:01 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-11-17 10:55:54 -0500 |
commit | ce394471d13bf071939a9a0b48c64c297676d233 (patch) | |
tree | ee67e3b6290218b6ecaebd09c1898cde2f3bd95a /kernel/kallsyms.c | |
parent | 74fcd524e808975dd546dac847119f1995a7c622 (diff) |
thread_group_cputime: kill the bogus ->signal != NULL check
Impact: simplify the code
thread_group_cputime() is called by current when it must have the valid
->signal, or under ->siglock, or under tasklist_lock after the ->signal
check, or the caller is wait_task_zombie() which reaps the child. In any
case ->signal can't be NULL.
But the point of this patch is not optimization. If it is possible to call
thread_group_cputime() when ->signal == NULL we are doing something wrong,
and we should not mask the problem. thread_group_cputime() fills *times
and the caller will use it, if we silently use task_struct->*times* we
report the wrong values.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/kallsyms.c')
0 files changed, 0 insertions, 0 deletions