diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2011-02-21 08:19:42 -0500 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2011-02-21 15:20:00 -0500 |
commit | 8fff39e06987492da3d4a0b9ec7cdbd245b6762b (patch) | |
tree | 751d1930d88def0238e927ac4e03f23703656a4d /kernel/irq | |
parent | ed4dea6e0e33a3e58d8b77b775a8f0e433e7a005 (diff) |
genirq: Add missing break in __irq_set_trigger()
The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/irq')
-rw-r--r-- | kernel/irq/manage.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 6cca1956c503..01f8a9519e63 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
567 | if (chip != desc->irq_data.chip) | 567 | if (chip != desc->irq_data.chip) |
568 | irq_chip_set_defaults(desc->irq_data.chip); | 568 | irq_chip_set_defaults(desc->irq_data.chip); |
569 | ret = 0; | 569 | ret = 0; |
570 | break; | ||
570 | default: | 571 | default: |
571 | pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", | 572 | pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", |
572 | flags, irq, chip->irq_set_type); | 573 | flags, irq, chip->irq_set_type); |