diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-02-17 14:43:37 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-02-17 14:44:47 -0500 |
commit | f17c75453b2d195eba0a90d9f16a3ba88c85b3b4 (patch) | |
tree | 2727a5965c34c11b11257db56fe87c432cd395ef /kernel/irq | |
parent | 8316e38100c70cd1443ac90074eccdd033aa218d (diff) |
irq: name 'p' variables a bit better
'p' stands for pointer - make it clear in setup_irq() and free_irq()
what kind of pointer it is.
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/irq')
-rw-r--r-- | kernel/irq/manage.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index de5a765e88ab..c589305210d7 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -399,7 +399,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
399 | static int | 399 | static int |
400 | __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | 400 | __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) |
401 | { | 401 | { |
402 | struct irqaction *old, **p; | 402 | struct irqaction *old, **old_ptr; |
403 | const char *old_name = NULL; | 403 | const char *old_name = NULL; |
404 | unsigned long flags; | 404 | unsigned long flags; |
405 | int shared = 0; | 405 | int shared = 0; |
@@ -431,8 +431,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
431 | * The following block of code has to be executed atomically | 431 | * The following block of code has to be executed atomically |
432 | */ | 432 | */ |
433 | spin_lock_irqsave(&desc->lock, flags); | 433 | spin_lock_irqsave(&desc->lock, flags); |
434 | p = &desc->action; | 434 | old_ptr = &desc->action; |
435 | old = *p; | 435 | old = *old_ptr; |
436 | if (old) { | 436 | if (old) { |
437 | /* | 437 | /* |
438 | * Can't share interrupts unless both agree to and are | 438 | * Can't share interrupts unless both agree to and are |
@@ -455,8 +455,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
455 | 455 | ||
456 | /* add new interrupt at end of irq queue */ | 456 | /* add new interrupt at end of irq queue */ |
457 | do { | 457 | do { |
458 | p = &old->next; | 458 | old_ptr = &old->next; |
459 | old = *p; | 459 | old = *old_ptr; |
460 | } while (old); | 460 | } while (old); |
461 | shared = 1; | 461 | shared = 1; |
462 | } | 462 | } |
@@ -507,7 +507,7 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
507 | (int)(new->flags & IRQF_TRIGGER_MASK)); | 507 | (int)(new->flags & IRQF_TRIGGER_MASK)); |
508 | } | 508 | } |
509 | 509 | ||
510 | *p = new; | 510 | *old_ptr = new; |
511 | 511 | ||
512 | /* Reset broken irq detection when installing new handler */ | 512 | /* Reset broken irq detection when installing new handler */ |
513 | desc->irq_count = 0; | 513 | desc->irq_count = 0; |
@@ -575,7 +575,7 @@ int setup_irq(unsigned int irq, struct irqaction *act) | |||
575 | void free_irq(unsigned int irq, void *dev_id) | 575 | void free_irq(unsigned int irq, void *dev_id) |
576 | { | 576 | { |
577 | struct irq_desc *desc = irq_to_desc(irq); | 577 | struct irq_desc *desc = irq_to_desc(irq); |
578 | struct irqaction *action, **p; | 578 | struct irqaction *action, **action_ptr; |
579 | unsigned long flags; | 579 | unsigned long flags; |
580 | 580 | ||
581 | WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); | 581 | WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); |
@@ -589,9 +589,9 @@ void free_irq(unsigned int irq, void *dev_id) | |||
589 | * There can be multiple actions per IRQ descriptor, find the right | 589 | * There can be multiple actions per IRQ descriptor, find the right |
590 | * one based on the dev_id: | 590 | * one based on the dev_id: |
591 | */ | 591 | */ |
592 | p = &desc->action; | 592 | action_ptr = &desc->action; |
593 | for (;;) { | 593 | for (;;) { |
594 | action = *p; | 594 | action = *action_ptr; |
595 | 595 | ||
596 | if (!action) { | 596 | if (!action) { |
597 | WARN(1, "Trying to free already-free IRQ %d\n", irq); | 597 | WARN(1, "Trying to free already-free IRQ %d\n", irq); |
@@ -602,11 +602,11 @@ void free_irq(unsigned int irq, void *dev_id) | |||
602 | 602 | ||
603 | if (action->dev_id == dev_id) | 603 | if (action->dev_id == dev_id) |
604 | break; | 604 | break; |
605 | p = &action->next; | 605 | action_ptr = &action->next; |
606 | } | 606 | } |
607 | 607 | ||
608 | /* Found it - now remove it from the list of entries: */ | 608 | /* Found it - now remove it from the list of entries: */ |
609 | *p = action->next; | 609 | *action_ptr = action->next; |
610 | 610 | ||
611 | /* Currently used only by UML, might disappear one day: */ | 611 | /* Currently used only by UML, might disappear one day: */ |
612 | #ifdef CONFIG_IRQ_RELEASE_METHOD | 612 | #ifdef CONFIG_IRQ_RELEASE_METHOD |