diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-03-06 10:44:14 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-03-06 10:45:01 -0500 |
commit | f0ef03985130287c6c84ebe69416cf790e6cc00e (patch) | |
tree | 3ecb04cc4d82e5fc3ae5f1747e6da172ae8cbcb7 /kernel/irq | |
parent | 16097439703bcd38e9fe5608c12add6dacb825ea (diff) | |
parent | 31bbed527e7039203920c51c9fb48c27aed0820c (diff) |
Merge branch 'x86/core' into tracing/textedit
Conflicts:
arch/x86/Kconfig
block/blktrace.c
kernel/irq/handle.c
Semantic conflict:
kernel/trace/blktrace.c
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/irq')
-rw-r--r-- | kernel/irq/chip.c | 5 | ||||
-rw-r--r-- | kernel/irq/handle.c | 57 | ||||
-rw-r--r-- | kernel/irq/internals.h | 7 | ||||
-rw-r--r-- | kernel/irq/manage.c | 12 | ||||
-rw-r--r-- | kernel/irq/migration.c | 12 | ||||
-rw-r--r-- | kernel/irq/numa_migrate.c | 19 | ||||
-rw-r--r-- | kernel/irq/proc.c | 4 |
7 files changed, 76 insertions, 40 deletions
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 7de11bd64dfe..122fef4b0bd3 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c | |||
@@ -46,7 +46,10 @@ void dynamic_irq_init(unsigned int irq) | |||
46 | desc->irq_count = 0; | 46 | desc->irq_count = 0; |
47 | desc->irqs_unhandled = 0; | 47 | desc->irqs_unhandled = 0; |
48 | #ifdef CONFIG_SMP | 48 | #ifdef CONFIG_SMP |
49 | cpumask_setall(&desc->affinity); | 49 | cpumask_setall(desc->affinity); |
50 | #ifdef CONFIG_GENERIC_PENDING_IRQ | ||
51 | cpumask_clear(desc->pending_mask); | ||
52 | #endif | ||
50 | #endif | 53 | #endif |
51 | spin_unlock_irqrestore(&desc->lock, flags); | 54 | spin_unlock_irqrestore(&desc->lock, flags); |
52 | } | 55 | } |
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index 4709a7c870d7..412370ab9a34 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <linux/rculist.h> | 18 | #include <linux/rculist.h> |
19 | #include <linux/hash.h> | 19 | #include <linux/hash.h> |
20 | #include <trace/irq.h> | 20 | #include <trace/irq.h> |
21 | #include <linux/bootmem.h> | ||
21 | 22 | ||
22 | #include "internals.h" | 23 | #include "internals.h" |
23 | 24 | ||
@@ -70,6 +71,7 @@ int nr_irqs = NR_IRQS; | |||
70 | EXPORT_SYMBOL_GPL(nr_irqs); | 71 | EXPORT_SYMBOL_GPL(nr_irqs); |
71 | 72 | ||
72 | #ifdef CONFIG_SPARSE_IRQ | 73 | #ifdef CONFIG_SPARSE_IRQ |
74 | |||
73 | static struct irq_desc irq_desc_init = { | 75 | static struct irq_desc irq_desc_init = { |
74 | .irq = -1, | 76 | .irq = -1, |
75 | .status = IRQ_DISABLED, | 77 | .status = IRQ_DISABLED, |
@@ -77,9 +79,6 @@ static struct irq_desc irq_desc_init = { | |||
77 | .handle_irq = handle_bad_irq, | 79 | .handle_irq = handle_bad_irq, |
78 | .depth = 1, | 80 | .depth = 1, |
79 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc_init.lock), | 81 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc_init.lock), |
80 | #ifdef CONFIG_SMP | ||
81 | .affinity = CPU_MASK_ALL | ||
82 | #endif | ||
83 | }; | 82 | }; |
84 | 83 | ||
85 | void init_kstat_irqs(struct irq_desc *desc, int cpu, int nr) | 84 | void init_kstat_irqs(struct irq_desc *desc, int cpu, int nr) |
@@ -114,6 +113,10 @@ static void init_one_irq_desc(int irq, struct irq_desc *desc, int cpu) | |||
114 | printk(KERN_ERR "can not alloc kstat_irqs\n"); | 113 | printk(KERN_ERR "can not alloc kstat_irqs\n"); |
115 | BUG_ON(1); | 114 | BUG_ON(1); |
116 | } | 115 | } |
116 | if (!init_alloc_desc_masks(desc, cpu, false)) { | ||
117 | printk(KERN_ERR "can not alloc irq_desc cpumasks\n"); | ||
118 | BUG_ON(1); | ||
119 | } | ||
117 | arch_init_chip_data(desc, cpu); | 120 | arch_init_chip_data(desc, cpu); |
118 | } | 121 | } |
119 | 122 | ||
@@ -122,7 +125,7 @@ static void init_one_irq_desc(int irq, struct irq_desc *desc, int cpu) | |||
122 | */ | 125 | */ |
123 | DEFINE_SPINLOCK(sparse_irq_lock); | 126 | DEFINE_SPINLOCK(sparse_irq_lock); |
124 | 127 | ||
125 | struct irq_desc *irq_desc_ptrs[NR_IRQS] __read_mostly; | 128 | struct irq_desc **irq_desc_ptrs __read_mostly; |
126 | 129 | ||
127 | static struct irq_desc irq_desc_legacy[NR_IRQS_LEGACY] __cacheline_aligned_in_smp = { | 130 | static struct irq_desc irq_desc_legacy[NR_IRQS_LEGACY] __cacheline_aligned_in_smp = { |
128 | [0 ... NR_IRQS_LEGACY-1] = { | 131 | [0 ... NR_IRQS_LEGACY-1] = { |
@@ -132,14 +135,10 @@ static struct irq_desc irq_desc_legacy[NR_IRQS_LEGACY] __cacheline_aligned_in_sm | |||
132 | .handle_irq = handle_bad_irq, | 135 | .handle_irq = handle_bad_irq, |
133 | .depth = 1, | 136 | .depth = 1, |
134 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc_init.lock), | 137 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc_init.lock), |
135 | #ifdef CONFIG_SMP | ||
136 | .affinity = CPU_MASK_ALL | ||
137 | #endif | ||
138 | } | 138 | } |
139 | }; | 139 | }; |
140 | 140 | ||
141 | /* FIXME: use bootmem alloc ...*/ | 141 | static unsigned int *kstat_irqs_legacy; |
142 | static unsigned int kstat_irqs_legacy[NR_IRQS_LEGACY][NR_CPUS]; | ||
143 | 142 | ||
144 | int __init early_irq_init(void) | 143 | int __init early_irq_init(void) |
145 | { | 144 | { |
@@ -149,18 +148,30 @@ int __init early_irq_init(void) | |||
149 | 148 | ||
150 | init_irq_default_affinity(); | 149 | init_irq_default_affinity(); |
151 | 150 | ||
151 | /* initialize nr_irqs based on nr_cpu_ids */ | ||
152 | arch_probe_nr_irqs(); | ||
153 | printk(KERN_INFO "NR_IRQS:%d nr_irqs:%d\n", NR_IRQS, nr_irqs); | ||
154 | |||
152 | desc = irq_desc_legacy; | 155 | desc = irq_desc_legacy; |
153 | legacy_count = ARRAY_SIZE(irq_desc_legacy); | 156 | legacy_count = ARRAY_SIZE(irq_desc_legacy); |
154 | 157 | ||
158 | /* allocate irq_desc_ptrs array based on nr_irqs */ | ||
159 | irq_desc_ptrs = alloc_bootmem(nr_irqs * sizeof(void *)); | ||
160 | |||
161 | /* allocate based on nr_cpu_ids */ | ||
162 | /* FIXME: invert kstat_irgs, and it'd be a per_cpu_alloc'd thing */ | ||
163 | kstat_irqs_legacy = alloc_bootmem(NR_IRQS_LEGACY * nr_cpu_ids * | ||
164 | sizeof(int)); | ||
165 | |||
155 | for (i = 0; i < legacy_count; i++) { | 166 | for (i = 0; i < legacy_count; i++) { |
156 | desc[i].irq = i; | 167 | desc[i].irq = i; |
157 | desc[i].kstat_irqs = kstat_irqs_legacy[i]; | 168 | desc[i].kstat_irqs = kstat_irqs_legacy + i * nr_cpu_ids; |
158 | lockdep_set_class(&desc[i].lock, &irq_desc_lock_class); | 169 | lockdep_set_class(&desc[i].lock, &irq_desc_lock_class); |
159 | 170 | init_alloc_desc_masks(&desc[i], 0, true); | |
160 | irq_desc_ptrs[i] = desc + i; | 171 | irq_desc_ptrs[i] = desc + i; |
161 | } | 172 | } |
162 | 173 | ||
163 | for (i = legacy_count; i < NR_IRQS; i++) | 174 | for (i = legacy_count; i < nr_irqs; i++) |
164 | irq_desc_ptrs[i] = NULL; | 175 | irq_desc_ptrs[i] = NULL; |
165 | 176 | ||
166 | return arch_early_irq_init(); | 177 | return arch_early_irq_init(); |
@@ -168,7 +179,10 @@ int __init early_irq_init(void) | |||
168 | 179 | ||
169 | struct irq_desc *irq_to_desc(unsigned int irq) | 180 | struct irq_desc *irq_to_desc(unsigned int irq) |
170 | { | 181 | { |
171 | return (irq < NR_IRQS) ? irq_desc_ptrs[irq] : NULL; | 182 | if (irq_desc_ptrs && irq < nr_irqs) |
183 | return irq_desc_ptrs[irq]; | ||
184 | |||
185 | return NULL; | ||
172 | } | 186 | } |
173 | 187 | ||
174 | struct irq_desc *irq_to_desc_alloc_cpu(unsigned int irq, int cpu) | 188 | struct irq_desc *irq_to_desc_alloc_cpu(unsigned int irq, int cpu) |
@@ -177,10 +191,9 @@ struct irq_desc *irq_to_desc_alloc_cpu(unsigned int irq, int cpu) | |||
177 | unsigned long flags; | 191 | unsigned long flags; |
178 | int node; | 192 | int node; |
179 | 193 | ||
180 | if (irq >= NR_IRQS) { | 194 | if (irq >= nr_irqs) { |
181 | printk(KERN_WARNING "irq >= NR_IRQS in irq_to_desc_alloc: %d %d\n", | 195 | WARN(1, "irq (%d) >= nr_irqs (%d) in irq_to_desc_alloc\n", |
182 | irq, NR_IRQS); | 196 | irq, nr_irqs); |
183 | WARN_ON(1); | ||
184 | return NULL; | 197 | return NULL; |
185 | } | 198 | } |
186 | 199 | ||
@@ -222,9 +235,6 @@ struct irq_desc irq_desc[NR_IRQS] __cacheline_aligned_in_smp = { | |||
222 | .handle_irq = handle_bad_irq, | 235 | .handle_irq = handle_bad_irq, |
223 | .depth = 1, | 236 | .depth = 1, |
224 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock), | 237 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock), |
225 | #ifdef CONFIG_SMP | ||
226 | .affinity = CPU_MASK_ALL | ||
227 | #endif | ||
228 | } | 238 | } |
229 | }; | 239 | }; |
230 | 240 | ||
@@ -236,12 +246,15 @@ int __init early_irq_init(void) | |||
236 | 246 | ||
237 | init_irq_default_affinity(); | 247 | init_irq_default_affinity(); |
238 | 248 | ||
249 | printk(KERN_INFO "NR_IRQS:%d\n", NR_IRQS); | ||
250 | |||
239 | desc = irq_desc; | 251 | desc = irq_desc; |
240 | count = ARRAY_SIZE(irq_desc); | 252 | count = ARRAY_SIZE(irq_desc); |
241 | 253 | ||
242 | for (i = 0; i < count; i++) | 254 | for (i = 0; i < count; i++) { |
243 | desc[i].irq = i; | 255 | desc[i].irq = i; |
244 | 256 | init_alloc_desc_masks(&desc[i], 0, true); | |
257 | } | ||
245 | return arch_early_irq_init(); | 258 | return arch_early_irq_init(); |
246 | } | 259 | } |
247 | 260 | ||
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index e6d0a43cc125..40416a81a0f5 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h | |||
@@ -16,7 +16,14 @@ extern int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
16 | extern struct lock_class_key irq_desc_lock_class; | 16 | extern struct lock_class_key irq_desc_lock_class; |
17 | extern void init_kstat_irqs(struct irq_desc *desc, int cpu, int nr); | 17 | extern void init_kstat_irqs(struct irq_desc *desc, int cpu, int nr); |
18 | extern spinlock_t sparse_irq_lock; | 18 | extern spinlock_t sparse_irq_lock; |
19 | |||
20 | #ifdef CONFIG_SPARSE_IRQ | ||
21 | /* irq_desc_ptrs allocated at boot time */ | ||
22 | extern struct irq_desc **irq_desc_ptrs; | ||
23 | #else | ||
24 | /* irq_desc_ptrs is a fixed size array */ | ||
19 | extern struct irq_desc *irq_desc_ptrs[NR_IRQS]; | 25 | extern struct irq_desc *irq_desc_ptrs[NR_IRQS]; |
26 | #endif | ||
20 | 27 | ||
21 | #ifdef CONFIG_PROC_FS | 28 | #ifdef CONFIG_PROC_FS |
22 | extern void register_irq_proc(unsigned int irq, struct irq_desc *desc); | 29 | extern void register_irq_proc(unsigned int irq, struct irq_desc *desc); |
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 291f03664552..a3a5dc9ef346 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -90,14 +90,14 @@ int irq_set_affinity(unsigned int irq, const struct cpumask *cpumask) | |||
90 | 90 | ||
91 | #ifdef CONFIG_GENERIC_PENDING_IRQ | 91 | #ifdef CONFIG_GENERIC_PENDING_IRQ |
92 | if (desc->status & IRQ_MOVE_PCNTXT || desc->status & IRQ_DISABLED) { | 92 | if (desc->status & IRQ_MOVE_PCNTXT || desc->status & IRQ_DISABLED) { |
93 | cpumask_copy(&desc->affinity, cpumask); | 93 | cpumask_copy(desc->affinity, cpumask); |
94 | desc->chip->set_affinity(irq, cpumask); | 94 | desc->chip->set_affinity(irq, cpumask); |
95 | } else { | 95 | } else { |
96 | desc->status |= IRQ_MOVE_PENDING; | 96 | desc->status |= IRQ_MOVE_PENDING; |
97 | cpumask_copy(&desc->pending_mask, cpumask); | 97 | cpumask_copy(desc->pending_mask, cpumask); |
98 | } | 98 | } |
99 | #else | 99 | #else |
100 | cpumask_copy(&desc->affinity, cpumask); | 100 | cpumask_copy(desc->affinity, cpumask); |
101 | desc->chip->set_affinity(irq, cpumask); | 101 | desc->chip->set_affinity(irq, cpumask); |
102 | #endif | 102 | #endif |
103 | desc->status |= IRQ_AFFINITY_SET; | 103 | desc->status |= IRQ_AFFINITY_SET; |
@@ -119,16 +119,16 @@ int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc) | |||
119 | * one of the targets is online. | 119 | * one of the targets is online. |
120 | */ | 120 | */ |
121 | if (desc->status & (IRQ_AFFINITY_SET | IRQ_NO_BALANCING)) { | 121 | if (desc->status & (IRQ_AFFINITY_SET | IRQ_NO_BALANCING)) { |
122 | if (cpumask_any_and(&desc->affinity, cpu_online_mask) | 122 | if (cpumask_any_and(desc->affinity, cpu_online_mask) |
123 | < nr_cpu_ids) | 123 | < nr_cpu_ids) |
124 | goto set_affinity; | 124 | goto set_affinity; |
125 | else | 125 | else |
126 | desc->status &= ~IRQ_AFFINITY_SET; | 126 | desc->status &= ~IRQ_AFFINITY_SET; |
127 | } | 127 | } |
128 | 128 | ||
129 | cpumask_and(&desc->affinity, cpu_online_mask, irq_default_affinity); | 129 | cpumask_and(desc->affinity, cpu_online_mask, irq_default_affinity); |
130 | set_affinity: | 130 | set_affinity: |
131 | desc->chip->set_affinity(irq, &desc->affinity); | 131 | desc->chip->set_affinity(irq, desc->affinity); |
132 | 132 | ||
133 | return 0; | 133 | return 0; |
134 | } | 134 | } |
diff --git a/kernel/irq/migration.c b/kernel/irq/migration.c index bd72329e630c..e05ad9be43b7 100644 --- a/kernel/irq/migration.c +++ b/kernel/irq/migration.c | |||
@@ -18,7 +18,7 @@ void move_masked_irq(int irq) | |||
18 | 18 | ||
19 | desc->status &= ~IRQ_MOVE_PENDING; | 19 | desc->status &= ~IRQ_MOVE_PENDING; |
20 | 20 | ||
21 | if (unlikely(cpumask_empty(&desc->pending_mask))) | 21 | if (unlikely(cpumask_empty(desc->pending_mask))) |
22 | return; | 22 | return; |
23 | 23 | ||
24 | if (!desc->chip->set_affinity) | 24 | if (!desc->chip->set_affinity) |
@@ -38,13 +38,13 @@ void move_masked_irq(int irq) | |||
38 | * For correct operation this depends on the caller | 38 | * For correct operation this depends on the caller |
39 | * masking the irqs. | 39 | * masking the irqs. |
40 | */ | 40 | */ |
41 | if (likely(cpumask_any_and(&desc->pending_mask, cpu_online_mask) | 41 | if (likely(cpumask_any_and(desc->pending_mask, cpu_online_mask) |
42 | < nr_cpu_ids)) { | 42 | < nr_cpu_ids)) { |
43 | cpumask_and(&desc->affinity, | 43 | cpumask_and(desc->affinity, |
44 | &desc->pending_mask, cpu_online_mask); | 44 | desc->pending_mask, cpu_online_mask); |
45 | desc->chip->set_affinity(irq, &desc->affinity); | 45 | desc->chip->set_affinity(irq, desc->affinity); |
46 | } | 46 | } |
47 | cpumask_clear(&desc->pending_mask); | 47 | cpumask_clear(desc->pending_mask); |
48 | } | 48 | } |
49 | 49 | ||
50 | void move_native_irq(int irq) | 50 | void move_native_irq(int irq) |
diff --git a/kernel/irq/numa_migrate.c b/kernel/irq/numa_migrate.c index acd88356ac76..7f9b80434e32 100644 --- a/kernel/irq/numa_migrate.c +++ b/kernel/irq/numa_migrate.c | |||
@@ -38,15 +38,22 @@ static void free_kstat_irqs(struct irq_desc *old_desc, struct irq_desc *desc) | |||
38 | old_desc->kstat_irqs = NULL; | 38 | old_desc->kstat_irqs = NULL; |
39 | } | 39 | } |
40 | 40 | ||
41 | static void init_copy_one_irq_desc(int irq, struct irq_desc *old_desc, | 41 | static bool init_copy_one_irq_desc(int irq, struct irq_desc *old_desc, |
42 | struct irq_desc *desc, int cpu) | 42 | struct irq_desc *desc, int cpu) |
43 | { | 43 | { |
44 | memcpy(desc, old_desc, sizeof(struct irq_desc)); | 44 | memcpy(desc, old_desc, sizeof(struct irq_desc)); |
45 | if (!init_alloc_desc_masks(desc, cpu, false)) { | ||
46 | printk(KERN_ERR "irq %d: can not get new irq_desc cpumask " | ||
47 | "for migration.\n", irq); | ||
48 | return false; | ||
49 | } | ||
45 | spin_lock_init(&desc->lock); | 50 | spin_lock_init(&desc->lock); |
46 | desc->cpu = cpu; | 51 | desc->cpu = cpu; |
47 | lockdep_set_class(&desc->lock, &irq_desc_lock_class); | 52 | lockdep_set_class(&desc->lock, &irq_desc_lock_class); |
48 | init_copy_kstat_irqs(old_desc, desc, cpu, nr_cpu_ids); | 53 | init_copy_kstat_irqs(old_desc, desc, cpu, nr_cpu_ids); |
54 | init_copy_desc_masks(old_desc, desc); | ||
49 | arch_init_copy_chip_data(old_desc, desc, cpu); | 55 | arch_init_copy_chip_data(old_desc, desc, cpu); |
56 | return true; | ||
50 | } | 57 | } |
51 | 58 | ||
52 | static void free_one_irq_desc(struct irq_desc *old_desc, struct irq_desc *desc) | 59 | static void free_one_irq_desc(struct irq_desc *old_desc, struct irq_desc *desc) |
@@ -76,12 +83,18 @@ static struct irq_desc *__real_move_irq_desc(struct irq_desc *old_desc, | |||
76 | node = cpu_to_node(cpu); | 83 | node = cpu_to_node(cpu); |
77 | desc = kzalloc_node(sizeof(*desc), GFP_ATOMIC, node); | 84 | desc = kzalloc_node(sizeof(*desc), GFP_ATOMIC, node); |
78 | if (!desc) { | 85 | if (!desc) { |
79 | printk(KERN_ERR "irq %d: can not get new irq_desc for migration.\n", irq); | 86 | printk(KERN_ERR "irq %d: can not get new irq_desc " |
87 | "for migration.\n", irq); | ||
88 | /* still use old one */ | ||
89 | desc = old_desc; | ||
90 | goto out_unlock; | ||
91 | } | ||
92 | if (!init_copy_one_irq_desc(irq, old_desc, desc, cpu)) { | ||
80 | /* still use old one */ | 93 | /* still use old one */ |
94 | kfree(desc); | ||
81 | desc = old_desc; | 95 | desc = old_desc; |
82 | goto out_unlock; | 96 | goto out_unlock; |
83 | } | 97 | } |
84 | init_copy_one_irq_desc(irq, old_desc, desc, cpu); | ||
85 | 98 | ||
86 | irq_desc_ptrs[irq] = desc; | 99 | irq_desc_ptrs[irq] = desc; |
87 | spin_unlock_irqrestore(&sparse_irq_lock, flags); | 100 | spin_unlock_irqrestore(&sparse_irq_lock, flags); |
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index aae3f742bcec..692363dd591f 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c | |||
@@ -20,11 +20,11 @@ static struct proc_dir_entry *root_irq_dir; | |||
20 | static int irq_affinity_proc_show(struct seq_file *m, void *v) | 20 | static int irq_affinity_proc_show(struct seq_file *m, void *v) |
21 | { | 21 | { |
22 | struct irq_desc *desc = irq_to_desc((long)m->private); | 22 | struct irq_desc *desc = irq_to_desc((long)m->private); |
23 | const struct cpumask *mask = &desc->affinity; | 23 | const struct cpumask *mask = desc->affinity; |
24 | 24 | ||
25 | #ifdef CONFIG_GENERIC_PENDING_IRQ | 25 | #ifdef CONFIG_GENERIC_PENDING_IRQ |
26 | if (desc->status & IRQ_MOVE_PENDING) | 26 | if (desc->status & IRQ_MOVE_PENDING) |
27 | mask = &desc->pending_mask; | 27 | mask = desc->pending_mask; |
28 | #endif | 28 | #endif |
29 | seq_cpumask(m, mask); | 29 | seq_cpumask(m, mask); |
30 | seq_putc(m, '\n'); | 30 | seq_putc(m, '\n'); |