diff options
author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 17:43:24 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:47 -0400 |
commit | b3ac022cb9dc5883505a88b159d1b240ad1ef405 (patch) | |
tree | bffa035303cbe3c5bde048ac3d3154fb57059e2d /kernel/fork.c | |
parent | dd98acf74762764fbc4382a1d9a244f11a2658cc (diff) |
proc: turn signal_struct->count into "int nr_threads"
No functional changes, just s/atomic_t count/int nr_threads/.
With the recent changes this counter has a single user, get_nr_threads()
And, none of its callers need the really accurate number of threads, not
to mention each caller obviously races with fork/exit. It is only used to
report this value to the user-space, except first_tid() uses it to avoid
the unnecessary while_each_thread() loop in the unlikely case.
It is a bit sad we need a word in struct signal_struct for this, perhaps
we can change get_nr_threads() to approximate the number of threads using
signal->live and kill ->nr_threads later.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/fork.c')
-rw-r--r-- | kernel/fork.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index 40cd099cfc1b..d32410bd4be7 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -877,9 +877,9 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) | |||
877 | if (!sig) | 877 | if (!sig) |
878 | return -ENOMEM; | 878 | return -ENOMEM; |
879 | 879 | ||
880 | atomic_set(&sig->sigcnt, 1); | 880 | sig->nr_threads = 1; |
881 | atomic_set(&sig->count, 1); | ||
882 | atomic_set(&sig->live, 1); | 881 | atomic_set(&sig->live, 1); |
882 | atomic_set(&sig->sigcnt, 1); | ||
883 | init_waitqueue_head(&sig->wait_chldexit); | 883 | init_waitqueue_head(&sig->wait_chldexit); |
884 | if (clone_flags & CLONE_NEWPID) | 884 | if (clone_flags & CLONE_NEWPID) |
885 | sig->flags |= SIGNAL_UNKILLABLE; | 885 | sig->flags |= SIGNAL_UNKILLABLE; |
@@ -1256,9 +1256,9 @@ static struct task_struct *copy_process(unsigned long clone_flags, | |||
1256 | } | 1256 | } |
1257 | 1257 | ||
1258 | if (clone_flags & CLONE_THREAD) { | 1258 | if (clone_flags & CLONE_THREAD) { |
1259 | atomic_inc(¤t->signal->sigcnt); | 1259 | current->signal->nr_threads++; |
1260 | atomic_inc(¤t->signal->count); | ||
1261 | atomic_inc(¤t->signal->live); | 1260 | atomic_inc(¤t->signal->live); |
1261 | atomic_inc(¤t->signal->sigcnt); | ||
1262 | p->group_leader = current->group_leader; | 1262 | p->group_leader = current->group_leader; |
1263 | list_add_tail_rcu(&p->thread_group, &p->group_leader->thread_group); | 1263 | list_add_tail_rcu(&p->thread_group, &p->group_leader->thread_group); |
1264 | } | 1264 | } |