aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/fork.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2008-02-06 04:36:13 -0500
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-06 13:41:00 -0500
commitd9ae90ac4bdce769ddb27c2e24c3351a30c3daf8 (patch)
tree220f88576b5c83369892ce13cb180bab6cccba7a /kernel/fork.c
parent06b8e878a9bc9301201cffe186eba99c4185f20a (diff)
use __set_task_state() for TRACED/STOPPED tasks
1. It is much easier to grep for ->state change if __set_task_state() is used instead of the direct assignment. 2. ptrace_stop() and handle_group_stop() use set_task_state() which adds the unneeded mb() (btw even if we use mb() it is still possible that do_wait() sees the new ->state but not ->exit_code, but this is ok). Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/fork.c')
-rw-r--r--kernel/fork.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/fork.c b/kernel/fork.c
index 2b55b74cd999..8adfe5ddb688 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1510,7 +1510,7 @@ long do_fork(unsigned long clone_flags,
1510 if (!(clone_flags & CLONE_STOPPED)) 1510 if (!(clone_flags & CLONE_STOPPED))
1511 wake_up_new_task(p, clone_flags); 1511 wake_up_new_task(p, clone_flags);
1512 else 1512 else
1513 p->state = TASK_STOPPED; 1513 __set_task_state(p, TASK_STOPPED);
1514 1514
1515 if (unlikely (trace)) { 1515 if (unlikely (trace)) {
1516 current->ptrace_message = nr; 1516 current->ptrace_message = nr;