diff options
author | Oleg Nesterov <oleg@redhat.com> | 2009-06-17 19:27:41 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-18 16:03:53 -0400 |
commit | a3f6dfb7295facb0505b5beca5a7ce48b0612379 (patch) | |
tree | 882e1103eaf759ab0e3bc53c08ff69b1f096b1bf /kernel/exit.c | |
parent | 64a16caf5e3417ee32f670debcb5857b02a9e08e (diff) |
do_wait: kill the old BUG_ON, use while_each_thread()
do_wait() does BUG_ON(tsk->signal != current->signal), this looks like a
raher obsolete check. At least, I don't think do_wait() is the best place
to verify that all threads have the same ->signal. Remove it.
Also, change the code to use while_each_thread().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/exit.c')
-rw-r--r-- | kernel/exit.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/exit.c b/kernel/exit.c index 9c6881a0a8b4..dd83c8419101 100644 --- a/kernel/exit.c +++ b/kernel/exit.c | |||
@@ -1595,9 +1595,7 @@ repeat: | |||
1595 | 1595 | ||
1596 | if (wo->wo_flags & __WNOTHREAD) | 1596 | if (wo->wo_flags & __WNOTHREAD) |
1597 | break; | 1597 | break; |
1598 | tsk = next_thread(tsk); | 1598 | } while_each_thread(current, tsk); |
1599 | BUG_ON(tsk->signal != current->signal); | ||
1600 | } while (tsk != current); | ||
1601 | read_unlock(&tasklist_lock); | 1599 | read_unlock(&tasklist_lock); |
1602 | 1600 | ||
1603 | notask: | 1601 | notask: |