diff options
author | Oleg Nesterov <oleg@redhat.com> | 2012-12-31 12:37:11 -0500 |
---|---|---|
committer | Oleg Nesterov <oleg@redhat.com> | 2013-02-08 11:47:13 -0500 |
commit | af4355e91f15812df8608925738c91be57c580dd (patch) | |
tree | d50a8fb2a2240f00e8d72a804de237552d7f1b36 /kernel/events | |
parent | 608e7427c0a06de0d70374a9fd7defc8eb228b7e (diff) |
uprobes: Kill the bogus IS_ERR_VALUE(xol_vaddr) check
utask->xol_vaddr is either zero or valid, remove the bogus
IS_ERR_VALUE() check in xol_free_insn_slot().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Anton Arapov <anton@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/events')
-rw-r--r-- | kernel/events/uprobes.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 071edcb3e62d..f6c7062fb950 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c | |||
@@ -1223,8 +1223,7 @@ static void xol_free_insn_slot(struct task_struct *tsk) | |||
1223 | return; | 1223 | return; |
1224 | 1224 | ||
1225 | slot_addr = tsk->utask->xol_vaddr; | 1225 | slot_addr = tsk->utask->xol_vaddr; |
1226 | 1226 | if (unlikely(!slot_addr)) | |
1227 | if (unlikely(!slot_addr || IS_ERR_VALUE(slot_addr))) | ||
1228 | return; | 1227 | return; |
1229 | 1228 | ||
1230 | area = tsk->mm->uprobes_state.xol_area; | 1229 | area = tsk->mm->uprobes_state.xol_area; |