diff options
author | Borislav Petkov <bp@suse.de> | 2014-06-04 19:11:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 19:54:17 -0400 |
commit | a8fe19ebfbfd90ec17c02284717238b02efb9580 (patch) | |
tree | b0bcae3df8f0f739993ede45c81c031d32d5edcd /kernel/debug/kdb | |
parent | 84b5ec8a9df86f3dcaaaf912715db35e4852d1da (diff) |
kernel/printk: use symbolic defines for console loglevels
... instead of naked numbers.
Stuff in sysrq.c used to set it to 8 which is supposed to mean above
default level so set it to DEBUG instead as we're terminating/killing all
tasks and we want to be verbose there.
Also, correct the check in x86_64_start_kernel which should be >= as
we're clearly issuing the string there for all debug levels, not only
the magical 10.
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Joe Perches <joe@perches.com>
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/debug/kdb')
-rw-r--r-- | kernel/debug/kdb/kdb_bt.c | 2 | ||||
-rw-r--r-- | kernel/debug/kdb/kdb_io.c | 2 | ||||
-rw-r--r-- | kernel/debug/kdb/kdb_main.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/kernel/debug/kdb/kdb_bt.c b/kernel/debug/kdb/kdb_bt.c index b03e0e814e43..fe15fff5df53 100644 --- a/kernel/debug/kdb/kdb_bt.c +++ b/kernel/debug/kdb/kdb_bt.c | |||
@@ -21,7 +21,7 @@ | |||
21 | static void kdb_show_stack(struct task_struct *p, void *addr) | 21 | static void kdb_show_stack(struct task_struct *p, void *addr) |
22 | { | 22 | { |
23 | int old_lvl = console_loglevel; | 23 | int old_lvl = console_loglevel; |
24 | console_loglevel = 15; | 24 | console_loglevel = CONSOLE_LOGLEVEL_MOTORMOUTH; |
25 | kdb_trap_printk++; | 25 | kdb_trap_printk++; |
26 | kdb_set_current_task(p); | 26 | kdb_set_current_task(p); |
27 | if (addr) { | 27 | if (addr) { |
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 14ff4849262c..7c70812caea5 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c | |||
@@ -710,7 +710,7 @@ kdb_printit: | |||
710 | } | 710 | } |
711 | if (logging) { | 711 | if (logging) { |
712 | saved_loglevel = console_loglevel; | 712 | saved_loglevel = console_loglevel; |
713 | console_loglevel = 0; | 713 | console_loglevel = CONSOLE_LOGLEVEL_SILENT; |
714 | printk(KERN_INFO "%s", kdb_buffer); | 714 | printk(KERN_INFO "%s", kdb_buffer); |
715 | } | 715 | } |
716 | 716 | ||
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 0b097c8a1e50..2f7c760305ca 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c | |||
@@ -1091,7 +1091,7 @@ static int kdb_reboot(int argc, const char **argv) | |||
1091 | static void kdb_dumpregs(struct pt_regs *regs) | 1091 | static void kdb_dumpregs(struct pt_regs *regs) |
1092 | { | 1092 | { |
1093 | int old_lvl = console_loglevel; | 1093 | int old_lvl = console_loglevel; |
1094 | console_loglevel = 15; | 1094 | console_loglevel = CONSOLE_LOGLEVEL_MOTORMOUTH; |
1095 | kdb_trap_printk++; | 1095 | kdb_trap_printk++; |
1096 | show_regs(regs); | 1096 | show_regs(regs); |
1097 | kdb_trap_printk--; | 1097 | kdb_trap_printk--; |