aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/cpuset.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2014-05-13 12:11:01 -0400
committerTejun Heo <tj@kernel.org>2014-05-13 12:11:01 -0400
commitec903c0c858e4963a9e0724bdcadfa837253341c (patch)
treeb52cd0d5bcac48d2d9c21e6186397c29ef89c33b /kernel/cpuset.c
parent46cfeb043b04f5878154bea36714709d46028495 (diff)
cgroup: rename css_tryget*() to css_tryget_online*()
Unlike the more usual refcnting, what css_tryget() provides is the distinction between online and offline csses instead of protection against upping a refcnt which already reached zero. cgroup is planning to provide actual tryget which fails if the refcnt already reached zero. Let's rename the existing trygets so that they clearly indicate that they're onliness. I thought about keeping the existing names as-are and introducing new names for the planned actual tryget; however, given that each controller participates in the synchronization of the online state, it seems worthwhile to make it explicit that these functions are about on/offline state. Rename css_tryget() to css_tryget_online() and css_tryget_from_dir() to css_tryget_online_from_dir(). This is pure rename. v2: cgroup_freezer grew new usages of css_tryget(). Update accordingly. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.cz> Acked-by: Li Zefan <lizefan@huawei.com> Cc: Vivek Goyal <vgoyal@redhat.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Diffstat (limited to 'kernel/cpuset.c')
-rw-r--r--kernel/cpuset.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 7c0e8da59e26..37ca0a5c226d 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -872,7 +872,7 @@ static void update_tasks_cpumask_hier(struct cpuset *root_cs, bool update_root)
872 continue; 872 continue;
873 } 873 }
874 } 874 }
875 if (!css_tryget(&cp->css)) 875 if (!css_tryget_online(&cp->css))
876 continue; 876 continue;
877 rcu_read_unlock(); 877 rcu_read_unlock();
878 878
@@ -1108,7 +1108,7 @@ static void update_tasks_nodemask_hier(struct cpuset *root_cs, bool update_root)
1108 continue; 1108 continue;
1109 } 1109 }
1110 } 1110 }
1111 if (!css_tryget(&cp->css)) 1111 if (!css_tryget_online(&cp->css))
1112 continue; 1112 continue;
1113 rcu_read_unlock(); 1113 rcu_read_unlock();
1114 1114
@@ -2153,7 +2153,7 @@ static void cpuset_hotplug_workfn(struct work_struct *work)
2153 2153
2154 rcu_read_lock(); 2154 rcu_read_lock();
2155 cpuset_for_each_descendant_pre(cs, pos_css, &top_cpuset) { 2155 cpuset_for_each_descendant_pre(cs, pos_css, &top_cpuset) {
2156 if (cs == &top_cpuset || !css_tryget(&cs->css)) 2156 if (cs == &top_cpuset || !css_tryget_online(&cs->css))
2157 continue; 2157 continue;
2158 rcu_read_unlock(); 2158 rcu_read_unlock();
2159 2159