diff options
author | Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> | 2012-05-24 10:17:03 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2012-07-24 07:53:28 -0400 |
commit | a1cd2b13f754b2c56fb87b8c4912c015f8f57c0c (patch) | |
tree | bb53414ee118a3807e5280ada2e26c1892c4dd18 /kernel/cpuset.c | |
parent | 7ddf96b02fe8dd441f452deef879040def5f7b34 (diff) |
cpusets: Remove/update outdated comments
cpuset_track_online_cpus() is no longer present. So remove the
outdated comment and replace it with reference to cpuset_update_active_cpus()
which is its equivalent.
Also, we don't lack memory hot-unplug anymore. And David Rientjes pointed
out how it is dealt with. So update that comment as well.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20120524141700.3692.98192.stgit@srivatsabhat.in.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/cpuset.c')
-rw-r--r-- | kernel/cpuset.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c index ba0a4d74d262..f33c7153b6d7 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c | |||
@@ -2034,9 +2034,8 @@ static struct cpuset *cpuset_next(struct list_head *queue) | |||
2034 | * before dropping down to the next. It always processes a node before | 2034 | * before dropping down to the next. It always processes a node before |
2035 | * any of its children. | 2035 | * any of its children. |
2036 | * | 2036 | * |
2037 | * For now, since we lack memory hot unplug, we'll never see a cpuset | 2037 | * In the case of memory hot-unplug, it will remove nodes from N_HIGH_MEMORY |
2038 | * that has tasks along with an empty 'mems'. But if we did see such | 2038 | * if all present pages from a node are offlined. |
2039 | * a cpuset, we'd handle it just like we do if its 'cpus' was empty. | ||
2040 | */ | 2039 | */ |
2041 | static void | 2040 | static void |
2042 | scan_cpusets_upon_hotplug(struct cpuset *root, enum hotplug_event event) | 2041 | scan_cpusets_upon_hotplug(struct cpuset *root, enum hotplug_event event) |
@@ -2137,7 +2136,7 @@ void cpuset_update_active_cpus(bool cpu_online) | |||
2137 | /* | 2136 | /* |
2138 | * Keep top_cpuset.mems_allowed tracking node_states[N_HIGH_MEMORY]. | 2137 | * Keep top_cpuset.mems_allowed tracking node_states[N_HIGH_MEMORY]. |
2139 | * Call this routine anytime after node_states[N_HIGH_MEMORY] changes. | 2138 | * Call this routine anytime after node_states[N_HIGH_MEMORY] changes. |
2140 | * See also the previous routine cpuset_track_online_cpus(). | 2139 | * See cpuset_update_active_cpus() for CPU hotplug handling. |
2141 | */ | 2140 | */ |
2142 | static int cpuset_track_online_nodes(struct notifier_block *self, | 2141 | static int cpuset_track_online_nodes(struct notifier_block *self, |
2143 | unsigned long action, void *arg) | 2142 | unsigned long action, void *arg) |