diff options
author | Gautham R Shenoy <ego@in.ibm.com> | 2007-05-09 05:34:41 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-09 15:30:53 -0400 |
commit | 7b0834c26fd796c79dfcc3939ed2b9122b75246f (patch) | |
tree | 870eb42cd02b9012fd0ab06d7efb5e7596376bad /kernel/cpu.c | |
parent | 10ab825bdef8df510f99c703a5a2d9b13a4e31a5 (diff) |
Remove kthread_bind() call from _cpu_down()
We are anyway kthread_stop()ping other per-cpu kernel threads after
move_task_off_dead_cpu(), so we can do it with the stop_machine_run thread
as well.
I just checked with Vatsa if there was any subtle reason why they
had put in the kthread_bind() in cpu.c. Vatsa cannot seem to recollect
any and I can't see any. So let us just remove the kthread_bind.
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/cpu.c')
-rw-r--r-- | kernel/cpu.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/kernel/cpu.c b/kernel/cpu.c index 1a823944e972..28cb6c71a47a 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c | |||
@@ -175,10 +175,6 @@ static int _cpu_down(unsigned int cpu) | |||
175 | /* This actually kills the CPU. */ | 175 | /* This actually kills the CPU. */ |
176 | __cpu_die(cpu); | 176 | __cpu_die(cpu); |
177 | 177 | ||
178 | /* Move it here so it can run. */ | ||
179 | kthread_bind(p, get_cpu()); | ||
180 | put_cpu(); | ||
181 | |||
182 | /* CPU is completely dead: tell everyone. Too late to complain. */ | 178 | /* CPU is completely dead: tell everyone. Too late to complain. */ |
183 | if (raw_notifier_call_chain(&cpu_chain, CPU_DEAD, hcpu) == NOTIFY_BAD) | 179 | if (raw_notifier_call_chain(&cpu_chain, CPU_DEAD, hcpu) == NOTIFY_BAD) |
184 | BUG(); | 180 | BUG(); |