diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-04-27 05:39:56 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-04-28 06:28:17 -0400 |
commit | 7719e437fac119e57b17588bab3a8e39ff9d22eb (patch) | |
tree | 56b08aec09225ac5587d9d8b7fee089181e26d25 /kernel/auditsc.c | |
parent | c782f242f0602edf848355d41e3676753c2280c8 (diff) |
[PATCH 2/2] audit: fix sparse shadowed variable warnings
Use msglen as the identifier.
kernel/audit.c:724:10: warning: symbol 'len' shadows an earlier one
kernel/audit.c:575:8: originally declared here
Don't use ino_f to check the inode field at the end of the functions.
kernel/auditfilter.c:429:22: warning: symbol 'f' shadows an earlier one
kernel/auditfilter.c:420:21: originally declared here
kernel/auditfilter.c:542:22: warning: symbol 'f' shadows an earlier one
kernel/auditfilter.c:529:21: originally declared here
i always used as a counter for a for loop and initialized to zero before
use. Eliminate the inner i variables.
kernel/auditsc.c:1295:8: warning: symbol 'i' shadows an earlier one
kernel/auditsc.c:1152:6: originally declared here
kernel/auditsc.c:1320:7: warning: symbol 'i' shadows an earlier one
kernel/auditsc.c:1152:6: originally declared here
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel/auditsc.c')
-rw-r--r-- | kernel/auditsc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index e128adcb33c2..091409996577 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c | |||
@@ -1293,7 +1293,6 @@ static void audit_log_exit(struct audit_context *context, struct task_struct *ts | |||
1293 | break; } | 1293 | break; } |
1294 | 1294 | ||
1295 | case AUDIT_SOCKETCALL: { | 1295 | case AUDIT_SOCKETCALL: { |
1296 | int i; | ||
1297 | struct audit_aux_data_socketcall *axs = (void *)aux; | 1296 | struct audit_aux_data_socketcall *axs = (void *)aux; |
1298 | audit_log_format(ab, "nargs=%d", axs->nargs); | 1297 | audit_log_format(ab, "nargs=%d", axs->nargs); |
1299 | for (i=0; i<axs->nargs; i++) | 1298 | for (i=0; i<axs->nargs; i++) |
@@ -1318,7 +1317,6 @@ static void audit_log_exit(struct audit_context *context, struct task_struct *ts | |||
1318 | 1317 | ||
1319 | for (aux = context->aux_pids; aux; aux = aux->next) { | 1318 | for (aux = context->aux_pids; aux; aux = aux->next) { |
1320 | struct audit_aux_data_pids *axs = (void *)aux; | 1319 | struct audit_aux_data_pids *axs = (void *)aux; |
1321 | int i; | ||
1322 | 1320 | ||
1323 | for (i = 0; i < axs->pid_count; i++) | 1321 | for (i = 0; i < axs->pid_count; i++) |
1324 | if (audit_log_pid_context(context, axs->target_pid[i], | 1322 | if (audit_log_pid_context(context, axs->target_pid[i], |