diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2014-02-28 13:49:05 -0500 |
---|---|---|
committer | Eric Paris <eparis@redhat.com> | 2014-03-20 10:10:53 -0400 |
commit | 638a0fd2a062568c568661be0a780be8e8836d03 (patch) | |
tree | e250ef6ef5ddf0ff6c189362b5e125c3a7bc402e /kernel/audit.h | |
parent | 3f1c82502c299da08b7b7f08b435212e51166ed9 (diff) |
audit: Use struct net not pid_t to remember the network namespce to reply in
While reading through 3.14-rc1 I found a pretty siginficant mishandling
of network namespaces in the recent audit changes.
In struct audit_netlink_list and audit_reply add a reference to the
network namespace of the caller and remove the userspace pid of the
caller. This cleanly remembers the callers network namespace, and
removes a huge class of races and nasty failure modes that can occur
when attempting to relook up the callers network namespace from a pid_t
(including the caller's network namespace changing, pid wraparound, and
the pid simply not being present).
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'kernel/audit.h')
-rw-r--r-- | kernel/audit.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/audit.h b/kernel/audit.h index 38c967d28de5..7bb65730c890 100644 --- a/kernel/audit.h +++ b/kernel/audit.h | |||
@@ -253,7 +253,7 @@ extern void audit_panic(const char *message); | |||
253 | 253 | ||
254 | struct audit_netlink_list { | 254 | struct audit_netlink_list { |
255 | __u32 portid; | 255 | __u32 portid; |
256 | pid_t pid; | 256 | struct net *net; |
257 | struct sk_buff_head q; | 257 | struct sk_buff_head q; |
258 | }; | 258 | }; |
259 | 259 | ||