diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-04-27 05:39:56 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-04-28 06:28:17 -0400 |
commit | 7719e437fac119e57b17588bab3a8e39ff9d22eb (patch) | |
tree | 56b08aec09225ac5587d9d8b7fee089181e26d25 /kernel/audit.c | |
parent | c782f242f0602edf848355d41e3676753c2280c8 (diff) |
[PATCH 2/2] audit: fix sparse shadowed variable warnings
Use msglen as the identifier.
kernel/audit.c:724:10: warning: symbol 'len' shadows an earlier one
kernel/audit.c:575:8: originally declared here
Don't use ino_f to check the inode field at the end of the functions.
kernel/auditfilter.c:429:22: warning: symbol 'f' shadows an earlier one
kernel/auditfilter.c:420:21: originally declared here
kernel/auditfilter.c:542:22: warning: symbol 'f' shadows an earlier one
kernel/auditfilter.c:529:21: originally declared here
i always used as a counter for a for loop and initialized to zero before
use. Eliminate the inner i variables.
kernel/auditsc.c:1295:8: warning: symbol 'i' shadows an earlier one
kernel/auditsc.c:1152:6: originally declared here
kernel/auditsc.c:1320:7: warning: symbol 'i' shadows an earlier one
kernel/auditsc.c:1152:6: originally declared here
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel/audit.c')
-rw-r--r-- | kernel/audit.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/audit.c b/kernel/audit.c index 5b9ad3dda885..f4799eb6977a 100644 --- a/kernel/audit.c +++ b/kernel/audit.c | |||
@@ -813,21 +813,21 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) | |||
813 | case AUDIT_MAKE_EQUIV: { | 813 | case AUDIT_MAKE_EQUIV: { |
814 | void *bufp = data; | 814 | void *bufp = data; |
815 | u32 sizes[2]; | 815 | u32 sizes[2]; |
816 | size_t len = nlmsg_len(nlh); | 816 | size_t msglen = nlmsg_len(nlh); |
817 | char *old, *new; | 817 | char *old, *new; |
818 | 818 | ||
819 | err = -EINVAL; | 819 | err = -EINVAL; |
820 | if (len < 2 * sizeof(u32)) | 820 | if (msglen < 2 * sizeof(u32)) |
821 | break; | 821 | break; |
822 | memcpy(sizes, bufp, 2 * sizeof(u32)); | 822 | memcpy(sizes, bufp, 2 * sizeof(u32)); |
823 | bufp += 2 * sizeof(u32); | 823 | bufp += 2 * sizeof(u32); |
824 | len -= 2 * sizeof(u32); | 824 | msglen -= 2 * sizeof(u32); |
825 | old = audit_unpack_string(&bufp, &len, sizes[0]); | 825 | old = audit_unpack_string(&bufp, &msglen, sizes[0]); |
826 | if (IS_ERR(old)) { | 826 | if (IS_ERR(old)) { |
827 | err = PTR_ERR(old); | 827 | err = PTR_ERR(old); |
828 | break; | 828 | break; |
829 | } | 829 | } |
830 | new = audit_unpack_string(&bufp, &len, sizes[1]); | 830 | new = audit_unpack_string(&bufp, &msglen, sizes[1]); |
831 | if (IS_ERR(new)) { | 831 | if (IS_ERR(new)) { |
832 | err = PTR_ERR(new); | 832 | err = PTR_ERR(new); |
833 | kfree(old); | 833 | kfree(old); |