Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

Pull vfs pile (part one) from Al Viro:
 "Assorted stuff - cleaning namei.c up a bit, fixing ->d_name/->d_parent
  locking violations, etc.

  The most visible changes here are death of FS_REVAL_DOT (replaced with
  "has ->d_weak_revalidate()") and a new helper getting from struct file
  to inode.  Some bits of preparation to xattr method interface changes.

  Misc patches by various people sent this cycle *and* ocfs2 fixes from
  several cycles ago that should've been upstream right then.

  PS: the next vfs pile will be xattr stuff."

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (46 commits)
  saner proc_get_inode() calling conventions
  proc: avoid extra pde_put() in proc_fill_super()
  fs: change return values from -EACCES to -EPERM
  fs/exec.c: make bprm_mm_init() static
  ocfs2/dlm: use GFP_ATOMIC inside a spin_lock
  ocfs2: fix possible use-after-free with AIO
  ocfs2: Fix oops in ocfs2_fast_symlink_readpage() code path
  get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero
  target: writev() on single-element vector is pointless
  export kernel_write(), convert open-coded instances
  fs: encode_fh: return FILEID_INVALID if invalid fid_type
  kill f_vfsmnt
  vfs: kill FS_REVAL_DOT by adding a d_weak_revalidate dentry op
  nfsd: handle vfs_getattr errors in acl protocol
  switch vfs_getattr() to struct path
  default SET_PERSONALITY() in linux/elf.h
  ceph: prepopulate inodes only when request is aborted
  d_hash_and_lookup(): export, switch open-coded instances
  9p: switch v9fs_set_create_acl() to inode+fid, do it before d_instantiate()
  9p: split dropping the acls from v9fs_set_create_acl()
  ...

2 files changed, 14 insertions, 13 deletions

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 023c9867ff43..e5c4f609f22c 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -477,7 +477,7 @@ static int mqueue_unlink(struct inode *dir, struct dentry *dentry)
 static ssize_t mqueue_read_file(struct file *filp, char __user *u_data,
                                 size_t count, loff_t *off)
 {
-        struct mqueue_inode_info *info = MQUEUE_I(filp->f_path.dentry->d_inode);
+        struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
         char buffer[FILENT_SIZE];
         ssize_t ret;
 
@@ -498,13 +498,13 @@ static ssize_t mqueue_read_file(struct file *filp, char __user *u_data,
         if (ret <= 0)
                 return ret;
 
-        filp->f_path.dentry->d_inode->i_atime = filp->f_path.dentry->d_inode->i_ctime = CURRENT_TIME;
+        file_inode(filp)->i_atime = file_inode(filp)->i_ctime = CURRENT_TIME;
         return ret;
 }
 
 static int mqueue_flush_file(struct file *filp, fl_owner_t id)
 {
-        struct mqueue_inode_info *info = MQUEUE_I(filp->f_path.dentry->d_inode);
+        struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
 
         spin_lock(&info->lock);
         if (task_tgid(current) == info->notify_owner)
@@ -516,7 +516,7 @@ static int mqueue_flush_file(struct file *filp, fl_owner_t id)
 
 static unsigned int mqueue_poll_file(struct file *filp, struct poll_table_struct *poll_tab)
 {
-        struct mqueue_inode_info *info = MQUEUE_I(filp->f_path.dentry->d_inode);
+        struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
         int retval = 0;
 
         poll_wait(filp, &info->wait_q, poll_tab);
@@ -973,7 +973,7 @@ SYSCALL_DEFINE5(mq_timedsend, mqd_t, mqdes, const char __user *, u_msg_ptr,
                 goto out;
         }
 
-        inode = f.file->f_path.dentry->d_inode;
+        inode = file_inode(f.file);
         if (unlikely(f.file->f_op != &mqueue_file_operations)) {
                 ret = -EBADF;
                 goto out_fput;
@@ -1089,7 +1089,7 @@ SYSCALL_DEFINE5(mq_timedreceive, mqd_t, mqdes, char __user *, u_msg_ptr,
                 goto out;
         }
 
-        inode = f.file->f_path.dentry->d_inode;
+        inode = file_inode(f.file);
         if (unlikely(f.file->f_op != &mqueue_file_operations)) {
                 ret = -EBADF;
                 goto out_fput;
@@ -1249,7 +1249,7 @@ retry:
                 goto out;
         }
 
-        inode = f.file->f_path.dentry->d_inode;
+        inode = file_inode(f.file);
         if (unlikely(f.file->f_op != &mqueue_file_operations)) {
                 ret = -EBADF;
                 goto out_fput;
@@ -1323,7 +1323,7 @@ SYSCALL_DEFINE3(mq_getsetattr, mqd_t, mqdes,
                 goto out;
         }
 
-        inode = f.file->f_path.dentry->d_inode;
+        inode = file_inode(f.file);
         if (unlikely(f.file->f_op != &mqueue_file_operations)) {
                 ret = -EBADF;
                 goto out_fput;
diff --git a/ipc/shm.c b/ipc/shm.c
index be3ec9ae454e..cb858df061d3 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -193,7 +193,7 @@ static void shm_destroy(struct ipc_namespace *ns, struct shmid_kernel *shp)
         if (!is_file_hugepages(shp->shm_file))
                 shmem_lock(shp->shm_file, 0, shp->mlock_user);
         else if (shp->mlock_user)
-                user_shm_unlock(shp->shm_file->f_path.dentry->d_inode->i_size,
+                user_shm_unlock(file_inode(shp->shm_file)->i_size,
                                                 shp->mlock_user);
         fput (shp->shm_file);
         security_shm_free(shp);
@@ -529,7 +529,7 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params)
          * shmid gets reported as "inode#" in /proc/pid/maps.
          * proc-ps tools use this. Changing this will break them.
          */
-        file->f_dentry->d_inode->i_ino = shp->shm_perm.id;
+        file_inode(file)->i_ino = shp->shm_perm.id;
 
         ns->shm_tot += numpages;
         error = shp->shm_perm.id;
@@ -678,7 +678,7 @@ static void shm_add_rss_swap(struct shmid_kernel *shp,
 {
         struct inode *inode;
 
-        inode = shp->shm_file->f_path.dentry->d_inode;
+        inode = file_inode(shp->shm_file);
 
         if (is_file_hugepages(shp->shm_file)) {
                 struct address_space *mapping = inode->i_mapping;
@@ -1042,7 +1042,8 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg, ulong *raddr,
                           is_file_hugepages(shp->shm_file) ?
                                 &shm_file_operations_huge :
                                 &shm_file_operations);
-        if (!file)
+        err = PTR_ERR(file);
+        if (IS_ERR(file))
                 goto out_free;
 
         file->private_data = sfd;
@@ -1175,7 +1176,7 @@ SYSCALL_DEFINE1(shmdt, char __user *, shmaddr)
                         (vma->vm_start - addr)/PAGE_SIZE == vma->vm_pgoff) {
 
 
-                        size = vma->vm_file->f_path.dentry->d_inode->i_size;
+                        size = file_inode(vma->vm_file)->i_size;
                         do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start);
                         /*
                          * We discovered the size of the shm segment, so