diff options
author | Stephen Rothwell <sfr@canb.auug.org.au> | 2005-09-06 18:16:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-07 19:57:19 -0400 |
commit | 202e5979af4d91c7ca05892641131dee22653259 (patch) | |
tree | ba8443571add62bc93d29c1f6a3575381cccd167 /ipc | |
parent | 8dbfc5cfdcac04d656f6f6789eb8fcdcc3d2dfda (diff) |
[PATCH] compat: be more consistent about [ug]id_t
When I first wrote the compat layer patches, I was somewhat cavalier about
the definition of compat_uid_t and compat_gid_t (or maybe I just
misunderstood :-)). This patch makes the compat types much more consistent
with the types we are being compatible with and hopefully will fix a few
bugs along the way.
compat type type in compat arch
__compat_[ug]id_t __kernel_[ug]id_t
__compat_[ug]id32_t __kernel_[ug]id32_t
compat_[ug]id_t [ug]id_t
The difference is that compat_uid_t is always 32 bits (for the archs we
care about) but __compat_uid_t may be 16 bits on some.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'ipc')
-rw-r--r-- | ipc/compat.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/ipc/compat.c b/ipc/compat.c index 3881d564c668..1fe95f6659dd 100644 --- a/ipc/compat.c +++ b/ipc/compat.c | |||
@@ -42,10 +42,10 @@ struct compat_msgbuf { | |||
42 | 42 | ||
43 | struct compat_ipc_perm { | 43 | struct compat_ipc_perm { |
44 | key_t key; | 44 | key_t key; |
45 | compat_uid_t uid; | 45 | __compat_uid_t uid; |
46 | compat_gid_t gid; | 46 | __compat_gid_t gid; |
47 | compat_uid_t cuid; | 47 | __compat_uid_t cuid; |
48 | compat_gid_t cgid; | 48 | __compat_gid_t cgid; |
49 | compat_mode_t mode; | 49 | compat_mode_t mode; |
50 | unsigned short seq; | 50 | unsigned short seq; |
51 | }; | 51 | }; |
@@ -174,8 +174,8 @@ static inline int __put_compat_ipc_perm(struct ipc64_perm *p, | |||
174 | struct compat_ipc_perm __user *up) | 174 | struct compat_ipc_perm __user *up) |
175 | { | 175 | { |
176 | int err; | 176 | int err; |
177 | compat_uid_t u; | 177 | __compat_uid_t u; |
178 | compat_gid_t g; | 178 | __compat_gid_t g; |
179 | 179 | ||
180 | err = __put_user(p->key, &up->key); | 180 | err = __put_user(p->key, &up->key); |
181 | SET_UID(u, p->uid); | 181 | SET_UID(u, p->uid); |