diff options
author | Pavel Emelianov <xemul@openvz.org> | 2006-11-03 01:07:03 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-11-03 15:27:56 -0500 |
commit | c7e12b838989b0e432c7a1cdf1e6c6fd936007f6 (patch) | |
tree | 31a6eea1d9ace0b467ab6bb209dd6a883910d682 /ipc/shm.c | |
parent | 733b72c31efb0d6b29577655939ccfe835381b52 (diff) |
[PATCH] Fix ipc entries removal
Fix two issuses related to ipc_ids->entries freeing.
1. When freeing ipc namespace we need to free entries allocated
with ipc_init_ids().
2. When removing old entries in grow_ary() ipc_rcu_putref()
may be called on entries set to &ids->nullentry earlier in
ipc_init_ids().
This is almost impossible without namespaces, but with
them this situation becomes possible.
Found during OpenVZ testing after obvious leaks in beancounters.
Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Cc: Kirill Korotaev <dev@openvz.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'ipc/shm.c')
-rw-r--r-- | ipc/shm.c | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -116,6 +116,7 @@ void shm_exit_ns(struct ipc_namespace *ns) | |||
116 | } | 116 | } |
117 | mutex_unlock(&shm_ids(ns).mutex); | 117 | mutex_unlock(&shm_ids(ns).mutex); |
118 | 118 | ||
119 | ipc_fini_ids(ns->ids[IPC_SHM_IDS]); | ||
119 | kfree(ns->ids[IPC_SHM_IDS]); | 120 | kfree(ns->ids[IPC_SHM_IDS]); |
120 | ns->ids[IPC_SHM_IDS] = NULL; | 121 | ns->ids[IPC_SHM_IDS] = NULL; |
121 | } | 122 | } |