aboutsummaryrefslogtreecommitdiffstats
path: root/ipc/namespace.c
diff options
context:
space:
mode:
authorSerge E. Hallyn <serge@hallyn.com>2011-03-23 19:43:24 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2011-03-23 22:47:08 -0400
commitb0e77598f87107001a00b8a4ece9c95e4254ccc4 (patch)
tree2738276570e4faa7c92a64521c192f04dca93801 /ipc/namespace.c
parentb515498f5bb5f38fc0e390b4ff7d00b6077de127 (diff)
userns: user namespaces: convert several capable() calls
CAP_IPC_OWNER and CAP_IPC_LOCK can be checked against current_user_ns(), because the resource comes from current's own ipc namespace. setuid/setgid are to uids in own namespace, so again checks can be against current_user_ns(). Changelog: Jan 11: Use task_ns_capable() in place of sched_capable(). Jan 11: Use nsown_capable() as suggested by Bastian Blank. Jan 11: Clarify (hopefully) some logic in futex and sched.c Feb 15: use ns_capable for ipc, not nsown_capable Feb 23: let copy_ipcs handle setting ipc_ns->user_ns Feb 23: pass ns down rather than taking it from current [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Serge E. Hallyn <serge.hallyn@canonical.com> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> Acked-by: David Howells <dhowells@redhat.com> Cc: James Morris <jmorris@namei.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'ipc/namespace.c')
-rw-r--r--ipc/namespace.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/ipc/namespace.c b/ipc/namespace.c
index aa1889962693..3c3e5223e7e5 100644
--- a/ipc/namespace.c
+++ b/ipc/namespace.c
@@ -15,7 +15,8 @@
15 15
16#include "util.h" 16#include "util.h"
17 17
18static struct ipc_namespace *create_ipc_ns(struct ipc_namespace *old_ns) 18static struct ipc_namespace *create_ipc_ns(struct task_struct *tsk,
19 struct ipc_namespace *old_ns)
19{ 20{
20 struct ipc_namespace *ns; 21 struct ipc_namespace *ns;
21 int err; 22 int err;
@@ -44,17 +45,19 @@ static struct ipc_namespace *create_ipc_ns(struct ipc_namespace *old_ns)
44 ipcns_notify(IPCNS_CREATED); 45 ipcns_notify(IPCNS_CREATED);
45 register_ipcns_notifier(ns); 46 register_ipcns_notifier(ns);
46 47
47 ns->user_ns = old_ns->user_ns; 48 ns->user_ns = get_user_ns(task_cred_xxx(tsk, user)->user_ns);
48 get_user_ns(ns->user_ns);
49 49
50 return ns; 50 return ns;
51} 51}
52 52
53struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns) 53struct ipc_namespace *copy_ipcs(unsigned long flags,
54 struct task_struct *tsk)
54{ 55{
56 struct ipc_namespace *ns = tsk->nsproxy->ipc_ns;
57
55 if (!(flags & CLONE_NEWIPC)) 58 if (!(flags & CLONE_NEWIPC))
56 return get_ipc_ns(ns); 59 return get_ipc_ns(ns);
57 return create_ipc_ns(ns); 60 return create_ipc_ns(tsk, ns);
58} 61}
59 62
60/* 63/*