diff options
author | Adrian Bunk <bunk@kernel.org> | 2008-02-06 04:37:51 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-06 13:41:08 -0500 |
commit | 6c81c32f9616fd6f2795dceae2f70943cb4d8609 (patch) | |
tree | fcafa4b8b071fc9d3a8ea87fd7a1fefca965a5a4 /init | |
parent | eb38a996ebacefe4ce2274de901138505d9cc96b (diff) |
calibrate_delay() must be __cpuinit
calibrate_delay() must be __cpuinit, not __{dev,}init.
I've verified that this is correct for all users.
While doing the latter, I also did the following cleanups:
- remove pointless additional prototypes in C files
- ensure all users #include <linux/delay.h>
This fixes the following section mismatches with CONFIG_HOTPLUG=n,
CONFIG_HOTPLUG_CPU=y:
WARNING: vmlinux.o(.text+0x1128d): Section mismatch: reference to .init.text.1:calibrate_delay (between 'check_cx686_slop' and 'set_cx86_reorder')
WARNING: vmlinux.o(.text+0x25102): Section mismatch: reference to .init.text.1:calibrate_delay (between 'smp_callin' and 'cpu_coregroup_map')
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Richard Henderson <rth@twiddle.net>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Christian Zankel <chris@zankel.net>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'init')
-rw-r--r-- | init/calibrate.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/init/calibrate.c b/init/calibrate.c index 1d87891b6fcd..ecb3822d4f70 100644 --- a/init/calibrate.c +++ b/init/calibrate.c | |||
@@ -28,7 +28,7 @@ __setup("lpj=", lpj_setup); | |||
28 | #define DELAY_CALIBRATION_TICKS ((HZ < 100) ? 1 : (HZ/100)) | 28 | #define DELAY_CALIBRATION_TICKS ((HZ < 100) ? 1 : (HZ/100)) |
29 | #define MAX_DIRECT_CALIBRATION_RETRIES 5 | 29 | #define MAX_DIRECT_CALIBRATION_RETRIES 5 |
30 | 30 | ||
31 | static unsigned long __devinit calibrate_delay_direct(void) | 31 | static unsigned long __cpuinit calibrate_delay_direct(void) |
32 | { | 32 | { |
33 | unsigned long pre_start, start, post_start; | 33 | unsigned long pre_start, start, post_start; |
34 | unsigned long pre_end, end, post_end; | 34 | unsigned long pre_end, end, post_end; |
@@ -101,7 +101,7 @@ static unsigned long __devinit calibrate_delay_direct(void) | |||
101 | return 0; | 101 | return 0; |
102 | } | 102 | } |
103 | #else | 103 | #else |
104 | static unsigned long __devinit calibrate_delay_direct(void) {return 0;} | 104 | static unsigned long __cpuinit calibrate_delay_direct(void) {return 0;} |
105 | #endif | 105 | #endif |
106 | 106 | ||
107 | /* | 107 | /* |
@@ -111,7 +111,7 @@ static unsigned long __devinit calibrate_delay_direct(void) {return 0;} | |||
111 | */ | 111 | */ |
112 | #define LPS_PREC 8 | 112 | #define LPS_PREC 8 |
113 | 113 | ||
114 | void __devinit calibrate_delay(void) | 114 | void __cpuinit calibrate_delay(void) |
115 | { | 115 | { |
116 | unsigned long ticks, loopbit; | 116 | unsigned long ticks, loopbit; |
117 | int lps_precision = LPS_PREC; | 117 | int lps_precision = LPS_PREC; |