aboutsummaryrefslogtreecommitdiffstats
path: root/init/do_mounts_rd.c
diff options
context:
space:
mode:
authorH Hartley Sweeten <hartleys@visionengravers.com>2012-05-31 19:26:10 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-05-31 20:49:27 -0400
commitc67e5382fb3f312c95d8d01db40fb398e6da454d (patch)
tree6e1830da7102e4f873d05b067aa39ba4425eefbc /init/do_mounts_rd.c
parent243f3803cf2a3665092c5fd6f924f453694681a6 (diff)
init: disable sparse checking of the mount.o source files
The init/mount.o source files produce a number of sparse warnings of the type: warning: incorrect type in argument 1 (different address spaces) expected char [noderef] <asn:1>*dev_name got char *name This is due to the syscalls expecting some of the arguments to be user pointers but they are being passed as kernel pointers. This is harmless but adds a lot of noise to a sparse build. To limit the noise just disable the sparse checking in the relevant source files, but still display a warning so that the user knows this has been done. Since the sparse checking has been disabled we can also remove the __user __force casts that are scattered thru the source. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'init/do_mounts_rd.c')
-rw-r--r--init/do_mounts_rd.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c
index 6212586df29a..6be2879cca66 100644
--- a/init/do_mounts_rd.c
+++ b/init/do_mounts_rd.c
@@ -1,3 +1,12 @@
1/*
2 * Many of the syscalls used in this file expect some of the arguments
3 * to be __user pointers not __kernel pointers. To limit the sparse
4 * noise, turn off sparse checking for this file.
5 */
6#ifdef __CHECKER__
7#undef __CHECKER__
8#warning "Sparse checking disabled for this file"
9#endif
1 10
2#include <linux/kernel.h> 11#include <linux/kernel.h>
3#include <linux/fs.h> 12#include <linux/fs.h>
@@ -181,7 +190,7 @@ int __init rd_load_image(char *from)
181 char rotator[4] = { '|' , '/' , '-' , '\\' }; 190 char rotator[4] = { '|' , '/' , '-' , '\\' };
182#endif 191#endif
183 192
184 out_fd = sys_open((const char __user __force *) "/dev/ram", O_RDWR, 0); 193 out_fd = sys_open("/dev/ram", O_RDWR, 0);
185 if (out_fd < 0) 194 if (out_fd < 0)
186 goto out; 195 goto out;
187 196
@@ -280,7 +289,7 @@ noclose_input:
280 sys_close(out_fd); 289 sys_close(out_fd);
281out: 290out:
282 kfree(buf); 291 kfree(buf);
283 sys_unlink((const char __user __force *) "/dev/ram"); 292 sys_unlink("/dev/ram");
284 return res; 293 return res;
285} 294}
286 295