diff options
author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-05-31 19:26:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-31 20:49:27 -0400 |
commit | c67e5382fb3f312c95d8d01db40fb398e6da454d (patch) | |
tree | 6e1830da7102e4f873d05b067aa39ba4425eefbc /init/do_mounts.c | |
parent | 243f3803cf2a3665092c5fd6f924f453694681a6 (diff) |
init: disable sparse checking of the mount.o source files
The init/mount.o source files produce a number of sparse warnings of the
type:
warning: incorrect type in argument 1 (different address spaces)
expected char [noderef] <asn:1>*dev_name
got char *name
This is due to the syscalls expecting some of the arguments to be user
pointers but they are being passed as kernel pointers. This is harmless
but adds a lot of noise to a sparse build.
To limit the noise just disable the sparse checking in the relevant source
files, but still display a warning so that the user knows this has been
done.
Since the sparse checking has been disabled we can also remove the __user
__force casts that are scattered thru the source.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'init/do_mounts.c')
-rw-r--r-- | init/do_mounts.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/init/do_mounts.c b/init/do_mounts.c index 42b0707c3481..d3f0aeed2d39 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c | |||
@@ -1,3 +1,13 @@ | |||
1 | /* | ||
2 | * Many of the syscalls used in this file expect some of the arguments | ||
3 | * to be __user pointers not __kernel pointers. To limit the sparse | ||
4 | * noise, turn off sparse checking for this file. | ||
5 | */ | ||
6 | #ifdef __CHECKER__ | ||
7 | #undef __CHECKER__ | ||
8 | #warning "Sparse checking disabled for this file" | ||
9 | #endif | ||
10 | |||
1 | #include <linux/module.h> | 11 | #include <linux/module.h> |
2 | #include <linux/sched.h> | 12 | #include <linux/sched.h> |
3 | #include <linux/ctype.h> | 13 | #include <linux/ctype.h> |
@@ -330,7 +340,7 @@ static int __init do_mount_root(char *name, char *fs, int flags, void *data) | |||
330 | if (err) | 340 | if (err) |
331 | return err; | 341 | return err; |
332 | 342 | ||
333 | sys_chdir((const char __user __force *)"/root"); | 343 | sys_chdir("/root"); |
334 | s = current->fs->pwd.dentry->d_sb; | 344 | s = current->fs->pwd.dentry->d_sb; |
335 | ROOT_DEV = s->s_dev; | 345 | ROOT_DEV = s->s_dev; |
336 | printk(KERN_INFO | 346 | printk(KERN_INFO |
@@ -556,5 +566,5 @@ void __init prepare_namespace(void) | |||
556 | out: | 566 | out: |
557 | devtmpfs_mount("dev"); | 567 | devtmpfs_mount("dev"); |
558 | sys_mount(".", "/", NULL, MS_MOVE, NULL); | 568 | sys_mount(".", "/", NULL, MS_MOVE, NULL); |
559 | sys_chroot((const char __user __force *)"."); | 569 | sys_chroot("."); |
560 | } | 570 | } |