diff options
author | Wu Fengguang <fengguang.wu@intel.com> | 2010-07-22 00:19:51 -0400 |
---|---|---|
committer | Wu Fengguang <fengguang.wu@intel.com> | 2011-06-07 20:25:23 -0400 |
commit | b7a2441f9966fe3e1be960a876ab52e6029ea005 (patch) | |
tree | f3e4373e6434bc21a4be983c3174aeb3298bf329 /include | |
parent | 3efaf0faba6793cd91298c76315e15de59c13ae0 (diff) |
writeback: remove writeback_control.more_io
When wbc.more_io was first introduced, it indicates whether there are
at least one superblock whose s_more_io contains more IO work. Now with
the per-bdi writeback, it can be replaced with a simple b_more_io test.
Acked-by: Jan Kara <jack@suse.cz>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/writeback.h | 1 | ||||
-rw-r--r-- | include/trace/events/ext4.h | 6 | ||||
-rw-r--r-- | include/trace/events/writeback.h | 5 |
3 files changed, 3 insertions, 9 deletions
diff --git a/include/linux/writeback.h b/include/linux/writeback.h index d8e96a480850..8797b20dd22b 100644 --- a/include/linux/writeback.h +++ b/include/linux/writeback.h | |||
@@ -46,7 +46,6 @@ struct writeback_control { | |||
46 | unsigned tagged_writepages:1; /* tag-and-write to avoid livelock */ | 46 | unsigned tagged_writepages:1; /* tag-and-write to avoid livelock */ |
47 | unsigned for_reclaim:1; /* Invoked from the page allocator */ | 47 | unsigned for_reclaim:1; /* Invoked from the page allocator */ |
48 | unsigned range_cyclic:1; /* range_start is cyclic */ | 48 | unsigned range_cyclic:1; /* range_start is cyclic */ |
49 | unsigned more_io:1; /* more io to be dispatched */ | ||
50 | }; | 49 | }; |
51 | 50 | ||
52 | /* | 51 | /* |
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h index e09592d2f916..b225d0d8c87f 100644 --- a/include/trace/events/ext4.h +++ b/include/trace/events/ext4.h | |||
@@ -404,7 +404,6 @@ TRACE_EVENT(ext4_da_writepages_result, | |||
404 | __field( int, pages_written ) | 404 | __field( int, pages_written ) |
405 | __field( long, pages_skipped ) | 405 | __field( long, pages_skipped ) |
406 | __field( int, sync_mode ) | 406 | __field( int, sync_mode ) |
407 | __field( char, more_io ) | ||
408 | __field( pgoff_t, writeback_index ) | 407 | __field( pgoff_t, writeback_index ) |
409 | ), | 408 | ), |
410 | 409 | ||
@@ -415,16 +414,15 @@ TRACE_EVENT(ext4_da_writepages_result, | |||
415 | __entry->pages_written = pages_written; | 414 | __entry->pages_written = pages_written; |
416 | __entry->pages_skipped = wbc->pages_skipped; | 415 | __entry->pages_skipped = wbc->pages_skipped; |
417 | __entry->sync_mode = wbc->sync_mode; | 416 | __entry->sync_mode = wbc->sync_mode; |
418 | __entry->more_io = wbc->more_io; | ||
419 | __entry->writeback_index = inode->i_mapping->writeback_index; | 417 | __entry->writeback_index = inode->i_mapping->writeback_index; |
420 | ), | 418 | ), |
421 | 419 | ||
422 | TP_printk("dev %d,%d ino %lu ret %d pages_written %d pages_skipped %ld " | 420 | TP_printk("dev %d,%d ino %lu ret %d pages_written %d pages_skipped %ld " |
423 | " more_io %d sync_mode %d writeback_index %lu", | 421 | "sync_mode %d writeback_index %lu", |
424 | MAJOR(__entry->dev), MINOR(__entry->dev), | 422 | MAJOR(__entry->dev), MINOR(__entry->dev), |
425 | (unsigned long) __entry->ino, __entry->ret, | 423 | (unsigned long) __entry->ino, __entry->ret, |
426 | __entry->pages_written, __entry->pages_skipped, | 424 | __entry->pages_written, __entry->pages_skipped, |
427 | __entry->more_io, __entry->sync_mode, | 425 | __entry->sync_mode, |
428 | (unsigned long) __entry->writeback_index) | 426 | (unsigned long) __entry->writeback_index) |
429 | ); | 427 | ); |
430 | 428 | ||
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index 4e249b927eaa..b2cfac5f3313 100644 --- a/include/trace/events/writeback.h +++ b/include/trace/events/writeback.h | |||
@@ -101,7 +101,6 @@ DECLARE_EVENT_CLASS(wbc_class, | |||
101 | __field(int, for_background) | 101 | __field(int, for_background) |
102 | __field(int, for_reclaim) | 102 | __field(int, for_reclaim) |
103 | __field(int, range_cyclic) | 103 | __field(int, range_cyclic) |
104 | __field(int, more_io) | ||
105 | __field(unsigned long, older_than_this) | 104 | __field(unsigned long, older_than_this) |
106 | __field(long, range_start) | 105 | __field(long, range_start) |
107 | __field(long, range_end) | 106 | __field(long, range_end) |
@@ -116,7 +115,6 @@ DECLARE_EVENT_CLASS(wbc_class, | |||
116 | __entry->for_background = wbc->for_background; | 115 | __entry->for_background = wbc->for_background; |
117 | __entry->for_reclaim = wbc->for_reclaim; | 116 | __entry->for_reclaim = wbc->for_reclaim; |
118 | __entry->range_cyclic = wbc->range_cyclic; | 117 | __entry->range_cyclic = wbc->range_cyclic; |
119 | __entry->more_io = wbc->more_io; | ||
120 | __entry->older_than_this = wbc->older_than_this ? | 118 | __entry->older_than_this = wbc->older_than_this ? |
121 | *wbc->older_than_this : 0; | 119 | *wbc->older_than_this : 0; |
122 | __entry->range_start = (long)wbc->range_start; | 120 | __entry->range_start = (long)wbc->range_start; |
@@ -124,7 +122,7 @@ DECLARE_EVENT_CLASS(wbc_class, | |||
124 | ), | 122 | ), |
125 | 123 | ||
126 | TP_printk("bdi %s: towrt=%ld skip=%ld mode=%d kupd=%d " | 124 | TP_printk("bdi %s: towrt=%ld skip=%ld mode=%d kupd=%d " |
127 | "bgrd=%d reclm=%d cyclic=%d more=%d older=0x%lx " | 125 | "bgrd=%d reclm=%d cyclic=%d older=0x%lx " |
128 | "start=0x%lx end=0x%lx", | 126 | "start=0x%lx end=0x%lx", |
129 | __entry->name, | 127 | __entry->name, |
130 | __entry->nr_to_write, | 128 | __entry->nr_to_write, |
@@ -134,7 +132,6 @@ DECLARE_EVENT_CLASS(wbc_class, | |||
134 | __entry->for_background, | 132 | __entry->for_background, |
135 | __entry->for_reclaim, | 133 | __entry->for_reclaim, |
136 | __entry->range_cyclic, | 134 | __entry->range_cyclic, |
137 | __entry->more_io, | ||
138 | __entry->older_than_this, | 135 | __entry->older_than_this, |
139 | __entry->range_start, | 136 | __entry->range_start, |
140 | __entry->range_end) | 137 | __entry->range_end) |