diff options
author | Roman Zippel <zippel@linux-m68k.org> | 2008-05-01 07:34:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-05-01 11:03:58 -0400 |
commit | f8bd2258e2d520dff28c855658bd24bdafb5102d (patch) | |
tree | d76db1dc858cb316bc7d5b8473f690a753fd2c93 /include | |
parent | 6f6d6a1a6a1336431a6cba60ace9e97c3a496a19 (diff) |
remove div_long_long_rem
x86 is the only arch right now, which provides an optimized for
div_long_long_rem and it has the downside that one has to be very careful that
the divide doesn't overflow.
The API is a little akward, as the arguments for the unsigned divide are
signed. The signed version also doesn't handle a negative divisor and
produces worse code on 64bit archs.
There is little incentive to keep this API alive, so this converts the few
users to the new API.
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: john stultz <johnstul@us.ibm.com>
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/asm-x86/div64.h | 18 | ||||
-rw-r--r-- | include/linux/calc64.h | 49 | ||||
-rw-r--r-- | include/linux/jiffies.h | 2 |
3 files changed, 1 insertions, 68 deletions
diff --git a/include/asm-x86/div64.h b/include/asm-x86/div64.h index 32fdbddaae55..9a2d644c08ef 100644 --- a/include/asm-x86/div64.h +++ b/include/asm-x86/div64.h | |||
@@ -33,24 +33,6 @@ | |||
33 | __mod; \ | 33 | __mod; \ |
34 | }) | 34 | }) |
35 | 35 | ||
36 | /* | ||
37 | * (long)X = ((long long)divs) / (long)div | ||
38 | * (long)rem = ((long long)divs) % (long)div | ||
39 | * | ||
40 | * Warning, this will do an exception if X overflows. | ||
41 | */ | ||
42 | #define div_long_long_rem(a, b, c) div_ll_X_l_rem(a, b, c) | ||
43 | |||
44 | static inline long div_ll_X_l_rem(long long divs, long div, long *rem) | ||
45 | { | ||
46 | long dum2; | ||
47 | asm("divl %2":"=a"(dum2), "=d"(*rem) | ||
48 | : "rm"(div), "A"(divs)); | ||
49 | |||
50 | return dum2; | ||
51 | |||
52 | } | ||
53 | |||
54 | static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder) | 36 | static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder) |
55 | { | 37 | { |
56 | union { | 38 | union { |
diff --git a/include/linux/calc64.h b/include/linux/calc64.h deleted file mode 100644 index ebf4b8f38d88..000000000000 --- a/include/linux/calc64.h +++ /dev/null | |||
@@ -1,49 +0,0 @@ | |||
1 | #ifndef _LINUX_CALC64_H | ||
2 | #define _LINUX_CALC64_H | ||
3 | |||
4 | #include <linux/types.h> | ||
5 | #include <asm/div64.h> | ||
6 | |||
7 | /* | ||
8 | * This is a generic macro which is used when the architecture | ||
9 | * specific div64.h does not provide a optimized one. | ||
10 | * | ||
11 | * The 64bit dividend is divided by the divisor (data type long), the | ||
12 | * result is returned and the remainder stored in the variable | ||
13 | * referenced by remainder (data type long *). In contrast to the | ||
14 | * do_div macro the dividend is kept intact. | ||
15 | */ | ||
16 | #ifndef div_long_long_rem | ||
17 | #define div_long_long_rem(dividend, divisor, remainder) \ | ||
18 | do_div_llr((dividend), divisor, remainder) | ||
19 | |||
20 | static inline unsigned long do_div_llr(const long long dividend, | ||
21 | const long divisor, long *remainder) | ||
22 | { | ||
23 | u64 result = dividend; | ||
24 | |||
25 | *(remainder) = do_div(result, divisor); | ||
26 | return (unsigned long) result; | ||
27 | } | ||
28 | #endif | ||
29 | |||
30 | /* | ||
31 | * Sign aware variation of the above. On some architectures a | ||
32 | * negative dividend leads to an divide overflow exception, which | ||
33 | * is avoided by the sign check. | ||
34 | */ | ||
35 | static inline long div_long_long_rem_signed(const long long dividend, | ||
36 | const long divisor, long *remainder) | ||
37 | { | ||
38 | long res; | ||
39 | |||
40 | if (unlikely(dividend < 0)) { | ||
41 | res = -div_long_long_rem(-dividend, divisor, remainder); | ||
42 | *remainder = -(*remainder); | ||
43 | } else | ||
44 | res = div_long_long_rem(dividend, divisor, remainder); | ||
45 | |||
46 | return res; | ||
47 | } | ||
48 | |||
49 | #endif | ||
diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index 33ef710dac24..abb6ac639e8e 100644 --- a/include/linux/jiffies.h +++ b/include/linux/jiffies.h | |||
@@ -1,7 +1,7 @@ | |||
1 | #ifndef _LINUX_JIFFIES_H | 1 | #ifndef _LINUX_JIFFIES_H |
2 | #define _LINUX_JIFFIES_H | 2 | #define _LINUX_JIFFIES_H |
3 | 3 | ||
4 | #include <linux/calc64.h> | 4 | #include <linux/math64.h> |
5 | #include <linux/kernel.h> | 5 | #include <linux/kernel.h> |
6 | #include <linux/types.h> | 6 | #include <linux/types.h> |
7 | #include <linux/time.h> | 7 | #include <linux/time.h> |