aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2009-03-25 11:48:35 -0400
committerIngo Molnar <mingo@elte.hu>2009-04-03 06:09:09 -0400
commit76791ab2d5e00c1eef728a8df4347ba133760fb8 (patch)
tree8065964f857f0627b4dd3ea041dfd4c92df70bc9 /include
parent3d544f411f2971eb82f5c52322251eb04494542a (diff)
kmemtrace, fs: uninline simple_transaction_set()
Impact: cleanup We want to remove percpu.h from rcupdate.h (for upcoming kmemtrace changes), but this is not possible currently without breaking the build because fs.h has an implicit include file depedency: it uses PAGE_SIZE but does not include asm/page.h which defines it. This problem gets masked in practice because most fs.h using sites use rcupreempt.h (and other headers) which includes percpu.h which brings in asm/page.h indirectly. We cannot add asm/page.h to asm/fs.h because page.h is not an exported header. Move simple_transaction_set() to the other simple-transaction file helpers in fs/libfs.c. This removes the include file hell and also reduces kernel size a bit. Acked-by: Al Viro <viro@zeniv.linux.org.uk> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: paulmck@linux.vnet.ibm.com LKML-Reference: <1237898630.25315.83.camel@penberg-laptop> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include')
-rw-r--r--include/linux/fs.h14
1 files changed, 1 insertions, 13 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h
index fc4dc28c5735..e4de2b543a73 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2323,19 +2323,7 @@ ssize_t simple_transaction_read(struct file *file, char __user *buf,
2323 size_t size, loff_t *pos); 2323 size_t size, loff_t *pos);
2324int simple_transaction_release(struct inode *inode, struct file *file); 2324int simple_transaction_release(struct inode *inode, struct file *file);
2325 2325
2326static inline void simple_transaction_set(struct file *file, size_t n) 2326void simple_transaction_set(struct file *file, size_t n);
2327{
2328 struct simple_transaction_argresp *ar = file->private_data;
2329
2330 BUG_ON(n > SIMPLE_TRANSACTION_LIMIT);
2331
2332 /*
2333 * The barrier ensures that ar->size will really remain zero until
2334 * ar->data is ready for reading.
2335 */
2336 smp_mb();
2337 ar->size = n;
2338}
2339 2327
2340/* 2328/*
2341 * simple attribute files 2329 * simple attribute files