aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-09-15 14:04:15 -0400
committerJeff Garzik <jeff@garzik.org>2006-09-19 00:29:20 -0400
commitfea63e38013ec628ab3f7fddc4c2148064b7910a (patch)
treea3e1cd7f50562a20584cd28ef9d71e0cd6c7c896 /include
parenta64f97f2c351410dfb3099c2369eacf7154b5532 (diff)
[PATCH] libata: fix non-uniform ports handling
Non-uniform ports handling got broken while updating libata to handle those in the same host. Only separate irq for the non-uniform secondary port was implemented while all other fields (host flags, transfer mode...) of the secondary port simply shared those of the first. For ata_piix combined mode, which ATM is the only user of non-uniform ports, this causes the secondary port assume the wrong type. This can cause PATA port to use SATA ops, which results in bogus check on PCS and detection failure. This patch adds ata_probe_ent->pinfo2 which points to optional port_info for the secondary port. For the time being, this seems to be the simplest solution. This workaround will be removed together with ata_probe_ent itself after init model is updated to allow more flexibility. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Nelson A. de Oliveira <naoliv@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'include')
-rw-r--r--include/linux/libata.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 8715305f611f..ff67e7524fe9 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -361,6 +361,14 @@ struct ata_probe_ent {
361 unsigned long _host_flags; 361 unsigned long _host_flags;
362 void __iomem *mmio_base; 362 void __iomem *mmio_base;
363 void *private_data; 363 void *private_data;
364
365 /* port_info for the secondary port. Together with irq2, it's
366 * used to implement non-uniform secondary port. Currently,
367 * the only user is ata_piix combined mode. This workaround
368 * will be removed together with ata_probe_ent when init model
369 * is updated.
370 */
371 const struct ata_port_info *pinfo2;
364}; 372};
365 373
366struct ata_host { 374struct ata_host {