diff options
author | Tejun Heo <htejun@gmail.com> | 2008-03-24 23:22:49 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:17 -0400 |
commit | 959471936241bd83da7d0a76411cef6772140fe6 (patch) | |
tree | abccf1d3931c17b581ee2c85cda05a603adcfb0f /include | |
parent | 887125e3740283be25564bfc6fb5d24974b651ab (diff) |
libata: kill port_info->sht and ->irq_handler
libata core layer doesn't care about sht or ->irq_handler. Those are
only of interest to the LLD during initialization. This is confusing
and has caused several drivers to have duplicate unused initializers
for these fields.
Currently only sata_nv uses these fields. Make sata_nv use
->private_data, which is supposed to carry LLD-specific information,
instead and kill ->sht and ->irq_handler. nv_pi_priv structure is
defined and struct literals are used to initialize private_data.
Notational overhead is negligible.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/libata.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h index e7f10a88efe1..88c6fa84ed74 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h | |||
@@ -748,14 +748,12 @@ struct ata_port_operations { | |||
748 | }; | 748 | }; |
749 | 749 | ||
750 | struct ata_port_info { | 750 | struct ata_port_info { |
751 | struct scsi_host_template *sht; | ||
752 | unsigned long flags; | 751 | unsigned long flags; |
753 | unsigned long link_flags; | 752 | unsigned long link_flags; |
754 | unsigned long pio_mask; | 753 | unsigned long pio_mask; |
755 | unsigned long mwdma_mask; | 754 | unsigned long mwdma_mask; |
756 | unsigned long udma_mask; | 755 | unsigned long udma_mask; |
757 | struct ata_port_operations *port_ops; | 756 | struct ata_port_operations *port_ops; |
758 | irq_handler_t irq_handler; | ||
759 | void *private_data; | 757 | void *private_data; |
760 | }; | 758 | }; |
761 | 759 | ||