diff options
author | Russell King - ARM Linux <linux@arm.linux.org.uk> | 2011-01-03 17:39:33 -0500 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2011-01-04 22:16:12 -0500 |
commit | 4983a04fd2562986360b646b378f267308bc22c0 (patch) | |
tree | 365b9fcfe69547f27dc1593565a07ad0465bf37c /include | |
parent | 19524d77ec34faf58d313ba34fb755ef6e159216 (diff) |
ARM: PL08x: move ccfg into txd structure
The ccfg register is used to configure the channel parameters - the type
and direction of transfer, the flow control signal and IRQ mask enables.
The type and direction of transfer is known in the relevent prep_*
function where a txd is created. The IRQ mask enables are always set,
and the flow control signals are always set when we start processing a
txd according to phychan->signal.
If we store the ccfg value in the txd structure, we can avoid modifying
platform data - and even having it in platform data at all.
So, remove it from platform data too.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/amba/pl08x.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h index 29d974562df9..8e74cb1845dd 100644 --- a/include/linux/amba/pl08x.h +++ b/include/linux/amba/pl08x.h | |||
@@ -58,7 +58,6 @@ struct pl08x_channel_data { | |||
58 | int max_signal; | 58 | int max_signal; |
59 | u32 muxval; | 59 | u32 muxval; |
60 | u32 cctl; | 60 | u32 cctl; |
61 | u32 ccfg; | ||
62 | dma_addr_t addr; | 61 | dma_addr_t addr; |
63 | bool circular_buffer; | 62 | bool circular_buffer; |
64 | bool single; | 63 | bool single; |
@@ -113,6 +112,11 @@ struct pl08x_txd { | |||
113 | void *llis_va; | 112 | void *llis_va; |
114 | struct pl08x_channel_data *cd; | 113 | struct pl08x_channel_data *cd; |
115 | bool active; | 114 | bool active; |
115 | /* | ||
116 | * Settings to be put into the physical channel when we | ||
117 | * trigger this txd. Other registers are in llis_va[0]. | ||
118 | */ | ||
119 | u32 ccfg; | ||
116 | }; | 120 | }; |
117 | 121 | ||
118 | /** | 122 | /** |